From 1a4af59a65dadc0c9aeda04843c27035324e1e6b Mon Sep 17 00:00:00 2001 From: clarissarichard <107963214+clarissarichard@users.noreply.github.com> Date: Mon, 11 Sep 2023 09:17:04 -0400 Subject: [PATCH] SFR-1752: Remove rspec workflow (#441) * Added Deprecated message to README * Removed rspec workflow yml file --- .github/workflows/rspec-integration-tests.yml | 41 ------------------- CHANGELOG.md | 1 + README.md | 4 ++ 3 files changed, 5 insertions(+), 41 deletions(-) delete mode 100644 .github/workflows/rspec-integration-tests.yml diff --git a/.github/workflows/rspec-integration-tests.yml b/.github/workflows/rspec-integration-tests.yml deleted file mode 100644 index 3da3975c..00000000 --- a/.github/workflows/rspec-integration-tests.yml +++ /dev/null @@ -1,41 +0,0 @@ -name: Rspec Regression Testing - -on: - # will run on all PRs that are opened or updated (synchronized) - pull_request: - branches: [production] - types: [opened, synchronize, reopened] - -jobs: - regression-test: - name: Run rspec regression tests - runs-on: ubuntu-latest - strategy: - matrix: - ruby-version: ["3.0.0"] - - env: - PA_TOKEN: ${{ secrets.CLONE_PAT }} - BASE_URL: ${{ secrets.RSPEC_TEST_URL }} - SEARCH_TERM: ${{ secrets.RSPEC_TEST_STRING }} - TEST_DRIVER: ${{ secrets.RSPEC_TEST_DRIVER }} - CATALOG_USERNAME: ${{ secrets.CATALOG_USERNAME }} - CATALOG_USER_PIN: ${{ secrets.CATALOG_USER_PIN }} - - services: - chrome: - image: selenium/standalone-chrome - - steps: - - name: Checkout rspec repo - run: git clone https://$PA_TOKEN@github.com/nypl/rspec_researchNow.git . - - - name: Set up Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: ${{ matrix.ruby-version }} - bundler-cache: true - - - name: Run regression tests (prefixed with number code) - run: bundle exec rspec -r ./spec/support/qa.rb --pattern spec/[12]?[0-9]*_spec.rb - diff --git a/CHANGELOG.md b/CHANGELOG.md index 6952d85f..d88e3f31 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ - Upgrade New Relic packages and update configuration - Update Adobe Analytics page names - SFR-1778: Fix failing Playwright tests +- SFR-1752: Remove rspec workflow ## [0.17.3] diff --git a/README.md b/README.md index e0f8c82f..4d3ce077 100644 --- a/README.md +++ b/README.md @@ -73,3 +73,7 @@ Term combinations ### Test To run unit tests, run `npm run test` in the terminal. + +### Deprecated + +As of September 2023, the [rspec-integration-tests.yml](https://github.com/NYPL/sfr-bookfinder-front-end/actions/workflows/rspec-integration-tests.yml) workflow is no longer in use and has been replaced by the [Playwright.yml](https://github.com/NYPL/sfr-bookfinder-front-end/blob/development/.github/workflows/Playwright.yml) workflow. Please contact the DRB team in Digital for more information.