Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate caching by nypl-data-api-client & disable? #87

Open
kfriedman opened this issue Sep 7, 2017 · 0 comments
Open

Investigate caching by nypl-data-api-client & disable? #87

kfriedman opened this issue Sep 7, 2017 · 0 comments

Comments

@kfriedman
Copy link

I believe the (unfortunate) default behavior of the nypl-data-api-client is to have caching enabled (see: https://github.com/NYPL-discovery/node-nypl-data-api-client/blob/master/README.md#clientget-path-opts).

This presents problems when there isn't a clear expiration policy or an API returns a bad response and the bad response gets cached. This happened yesterday during our Sierra issues when bad Patron information was cached by the deliveryLocationsByBarcode endpoint. I was forced to bounce the server to resolve the issue.

@EdwinGuzman also had a similar issue with the Discovery UI so we can compare notes with him.

If caching is enabled, should we disable it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant