Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deliveryLocationsByBarcode better error handling #57

Open
nonword opened this issue Jul 13, 2017 · 0 comments
Open

deliveryLocationsByBarcode better error handling #57

nonword opened this issue Jul 13, 2017 · 0 comments

Comments

@nonword
Copy link
Member

nonword commented Jul 13, 2017

  1. Endpoint should fail in some way if barcodes param empty/missing. Currently returns an item [mis]serialized with 'urn:barcode:undefined'!

  2. While we're at it, endpoint should be more helpful when no barcodes match. Currently returns 500. This isn't a server error. It's a client error if it's an error. Maybe something in the 4** range is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant