From 79d5ca9edcf4e590656fefd425c57fdac71db067 Mon Sep 17 00:00:00 2001 From: Paul Beaudoin Date: Tue, 2 Apr 2024 14:01:26 -0400 Subject: [PATCH 1/3] Update onsite-edd critiera to match sheet Update onsite-edd criteria to match location critiera in: https://docs.google.com/spreadsheets/d/1fTZlmvT39Yk3ZAeYR2qNNwIUIhWhBY1XpOUPaYTeOL8 - Spreadsheet removed maff1, magg1, magh1, maii1, mall1, mapp1, & scff1 in Aug 2021 - Spreadsheet has myh22 (pah22) and mym22 (pam22), so adding those. --- data/onsite-edd-criteria.json | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/data/onsite-edd-criteria.json b/data/onsite-edd-criteria.json index 233ed669..21ff7b04 100644 --- a/data/onsite-edd-criteria.json +++ b/data/onsite-edd-criteria.json @@ -34,19 +34,15 @@ "maf", "maf82", "maf92", - "maff1", "maff3", "mag", "mag82", "mag92", - "magg1", "magg2", "magg3", - "magh1", "mai", "mai82", "mai92", - "maii1", "maii2", "maii3", "maj92", @@ -57,13 +53,11 @@ "mal72", "mal82", "mal92", - "mall1", "malm2", "malv2", "map", "map82", "map92", - "mapp1", "mapp2", "mapp3", "mas62", @@ -71,7 +65,9 @@ "mas92", "pad22", "pad32", + "pam22", "pah", + "pah22", "pah32", "pam", "pam32", @@ -80,7 +76,6 @@ "pat22", "pat32", "scf", - "scff1", "scff2", "scff3" ] From ac14074eef08300a77ca80ee7b42786545337203 Mon Sep 17 00:00:00 2001 From: Paul Beaudoin Date: Tue, 2 Apr 2024 14:09:34 -0400 Subject: [PATCH 2/3] Fix onsite requestability test --- test/delivery-locations-resolver.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/delivery-locations-resolver.test.js b/test/delivery-locations-resolver.test.js index 957f92b2..e93b312c 100644 --- a/test/delivery-locations-resolver.test.js +++ b/test/delivery-locations-resolver.test.js @@ -44,7 +44,7 @@ var sampleItems = { 'uri': 'i12227153', 'holdingLocation': [ { - 'id': 'loc:scff1', + 'id': 'loc:scf', 'label': 'Schomburg Center - Research & Reference' } ], From 63fe6c7507d57c4ea4de42167b456822325e02f5 Mon Sep 17 00:00:00 2001 From: Paul Beaudoin Date: Tue, 9 Apr 2024 14:19:39 -0400 Subject: [PATCH 3/3] Trivial --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 855e2e41..0870f000 100644 --- a/README.md +++ b/README.md @@ -242,3 +242,4 @@ There is currently one feature flag in this app, which is 'no-on-site-edd'. When NB: numAvailable and numItem*Parsed counts do not **exclude** the e-item, but these items are not indexed with statuses, volumes, or date ranges, and are therefore not actually included in this count. NB: As the table above indicates, there is a mismatch between what the front end and API regard as "electronic items". As far as the API is concerned, there is only at most ONE electronic item, which can have many electronic locator values. `numElectronicResources` counts these locator values, but the other item count values treat all the electronic resources as a single item. +