Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUDIT] Use stack-based iterative computation to avoid creating many Scala List objects for deep expression trees #11754

Open
jlowe opened this issue Nov 22, 2024 · 0 comments
Open

[AUDIT] Use stack-based iterative computation to avoid creating many Scala List objects for deep expression trees #11754

jlowe opened this issue Nov 22, 2024 · 0 comments
Labels
audit General label for audit related tasks audit_4.0.0 Audit related tasks for 4.0.0 Spark 4.0+ Spark 4.0+ issues

Comments

@jlowe
Copy link
Member

jlowe commented Nov 22, 2024

SPARK-49977 changed the gatherCommutative method from a recursive use of flatMap to an interative method to avoid heap object problems with deep expression trees. We have similar code in GpuCanonicalize.gatherCommutative and should update accordingly.
@jlowe jlowe added ? - Needs Triage Need team to review and classify audit General label for audit related tasks audit_4.0.0 Audit related tasks for 4.0.0 labels Nov 22, 2024
@mattahrens mattahrens added Spark 4.0+ Spark 4.0+ issues and removed ? - Needs Triage Need team to review and classify labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit General label for audit related tasks audit_4.0.0 Audit related tasks for 4.0.0 Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlowe @mattahrens