Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] [Follow-up] Enable nested type for GpuXxHash64 #11704

Open
res-life opened this issue Nov 7, 2024 · 0 comments
Open

[FEA] [Follow-up] Enable nested type for GpuXxHash64 #11704

res-life opened this issue Nov 7, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@res-life
Copy link
Collaborator

res-life commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
PR added the ability to support nested type for XxHash64. Originally it's required by Hyper log log plus plus(HLL++) to fix NVIDIA/spark-rapids-jni#2574. As a byproduct, we can enable nested type for GpuXxHash64 in Spark-Rapids.

Describe the solution you'd like

  • check the nested type depth, note consecutive lists only count for one depth. For more details, refer to the JNI repo PR.
  • map is list of struct in CUDF, so map should count for two depth.

Additional context
It's just a byproduct, currently is not required by any customer.
The priority should be low.

@res-life res-life added ? - Needs Triage Need team to review and classify feature request New feature or request labels Nov 7, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants