generator: promote OpenAICompatible as first class generator #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartin-tech
changed the title
Various generators extend this base template, usage and feedback suggest UX and usability improvements will be gained by promoting this class to be a `Configurable` generic OpenAI client based generator. * default `uri` * default implmentations of `_load_client()` and `_clear_client()` * remove duplicate versions of `_clear_client()` Signed-off-by: Jeffrey Martin <[email protected]>
jmartin-tech
force-pushed
the
feature/promote-OpenAICompatible
branch
from
f470652 to
5c56469
Compare
Signed-off-by: Jeffrey Martin <[email protected]>
leondz
requested changes
Nov 25, 2024
jmartin-tech
changed the title
Signed-off-by: Jeffrey Martin <[email protected]>
|
@leondz since we are going to defer the rename, can this get an approval to land? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1008
Various generators extend this base template, usage and feedback suggest UX and usability improvements will be gained by promoting this class to be a
Configurablegeneric OpenAI client based generator.Verification
List the steps needed to make sure this thing works
nimconfiguration via generator config options:compatible.json:
{ "openai": { "OpenAICompatible": { "uri": "https://integrate.api.nvidia.com/v1/", "suppressed_params": ["n", "frequency_penalty", "presence_penalty"] } } }groq/openai.OpenAIGenerator/nimwith--parallel_attemptsenabled.