Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs, tests, and samples for StridedMemoryView/@viewable #247

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leofang
Copy link
Member

@leofang leofang commented Nov 16, 2024

Close #143. Close #236.

@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! test Addition or improved tests cuda.core Everything related to the cuda.core module labels Nov 16, 2024
@leofang leofang added this to the cuda.core beta 2 milestone Nov 16, 2024
@leofang leofang self-assigned this Nov 16, 2024
Copy link

copy-pr-bot bot commented Nov 16, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment on lines -29 to +81
device_id: int = None # -1 for CPU
device_id: int = None # 0 for CPU
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Need to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module documentation Improvements or additions to documentation P0 High priority - Must do! test Addition or improved tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document StridedMemoryView and @viewable Add a sample code for StridedMemoryView
1 participant