From 5aacb982f62ab103babfd5332195df6a30394f23 Mon Sep 17 00:00:00 2001 From: Richard Michael Date: Thu, 25 Jul 2024 09:24:53 -0700 Subject: [PATCH 1/3] Trivial typos in tutorial notebooks. Signed-off-by: Richard Michael --- tutorials/00_NeMo_Primer.ipynb | 2 +- tutorials/01_NeMo_Models.ipynb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tutorials/00_NeMo_Primer.ipynb b/tutorials/00_NeMo_Primer.ipynb index a7198103cff7..d69292eb1780 100644 --- a/tutorials/00_NeMo_Primer.ipynb +++ b/tutorials/00_NeMo_Primer.ipynb @@ -1249,7 +1249,7 @@ "\n", "Tutorials are meant to be more in-depth explanation of the workflow in the discussed task - usually involving a small amount of data to train a small model on a task, along with some explanation of the task itself.\n", "\n", - "While the tutorials are a great example of the simplicity of NeMo, please note for the best performance when training on real datasets, we advice the use of the example scripts instead of the tutorial notebooks. \n", + "While the tutorials are a great example of the simplicity of NeMo, please note for the best performance when training on real datasets, we advise the use of the example scripts instead of the tutorial notebooks. \n", "\n", "NeMo Tutorials directory can be found here - https://github.com/NVIDIA/NeMo/tree/main/tutorials" ] diff --git a/tutorials/01_NeMo_Models.ipynb b/tutorials/01_NeMo_Models.ipynb index 4183ffd68a71..5392f617721a 100644 --- a/tutorials/01_NeMo_Models.ipynb +++ b/tutorials/01_NeMo_Models.ipynb @@ -974,7 +974,7 @@ "-------\n", "**Remember**:\n", "\n", - " - The NeMo equivalent of `torch.nn.Module` is the `NeuralModule.\n", + " - The NeMo equivalent of `torch.nn.Module` is the `NeuralModule`.\n", " - The NeMo equivalent of the `LightningModule` is `ModelPT`.\n" ] }, From 82de49929280e93b2900b30c4facc65c901cd793 Mon Sep 17 00:00:00 2001 From: Richard Michael Date: Thu, 25 Jul 2024 09:26:29 -0700 Subject: [PATCH 2/3] Explicit numpy<2, to avoid numpy2 if 1.x is not present Signed-off-by: Richard Michael --- requirements/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements/requirements.txt b/requirements/requirements.txt index 3169d31dbeed..c3451e5a559d 100644 --- a/requirements/requirements.txt +++ b/requirements/requirements.txt @@ -1,7 +1,7 @@ fiddle huggingface_hub>=0.24 numba -numpy>=1.22 +numpy>=1.22,<2.0 onnx>=1.7.0 python-dateutil ruamel.yaml From 946891dc244f2775eac849e0c3c559639d87f8ae Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 25 Jul 2024 16:45:06 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- requirements/requirements_asr.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements/requirements_asr.txt b/requirements/requirements_asr.txt index 7745f5326047..2176522490d4 100644 --- a/requirements/requirements_asr.txt +++ b/requirements/requirements_asr.txt @@ -2,6 +2,7 @@ braceexpand editdistance einops g2p_en +IPython jiwer kaldi-python-io kaldiio