Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0rc1 #9675

Closed
wants to merge 7 commits into from
Closed

Release 2.0.0rc1 #9675

wants to merge 7 commits into from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jul 10, 2024

🚀 PR to release NeMo 2.0.0rc1.

📝 Please remember the following to-do's before merge:

  • Fill-in the comment Highlights
  • Review the comment Detailed Changelogs

🚨 Please also keep in mind to not delete the headings of the task commits. They are required by the post-merge automation.

🙏 Please merge this PR only if the CI workflow completed successfully.

cuichenx and others added 7 commits July 8, 2024 19:37
* Fix when optimizers are setup for PEFT

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

* Init DDP inside PEFT

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

* Some fixes, loss seems to become nan with peft for some reason

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

* Loss goes down on fp32

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

* Simplifying FNMixin

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

* Fix bug with new checkpoint-io

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

* Fix failing test: test_peft_on_train_epoch_start_with_adapter

* Apply isort and black reformatting

Signed-off-by: marcromeyn <[email protected]>

---------

Signed-off-by: marcromeyn <[email protected]>
Co-authored-by: marcromeyn <[email protected]>
Co-authored-by: Chen Cui <[email protected]>
Signed-off-by: huvunvidia <[email protected]>
Co-authored-by: huvunvidia <[email protected]>
Signed-off-by: huvunvidia <[email protected]>
Co-authored-by: huvunvidia <[email protected]>
* Parametrize FPS group

Signed-off-by: Mikołaj Błaż <[email protected]>

* Apply isort and black reformatting

Signed-off-by: mikolajblaz <[email protected]>

* Change deafult to False

Signed-off-by: Mikołaj Błaż <[email protected]>

* Add logic to new ckptIO

Signed-off-by: Mikołaj Błaż <[email protected]>

* Turn on parallel save by default

Signed-off-by: Mikołaj Błaż <[email protected]>

---------

Signed-off-by: Mikołaj Błaż <[email protected]>
Signed-off-by: mikolajblaz <[email protected]>
Co-authored-by: Dmytro Pykhtar <[email protected]>
@github-actions github-actions bot added the NLP label Jul 10, 2024
@ko3n1g ko3n1g changed the title R2.0.0rc1 Release 2.0.0rc1 Jul 10, 2024
@ko3n1g ko3n1g closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants