unpin transformers version #9606

dimapihtar · 2024-07-03T15:39:31Z

What does this PR do ?

Unpins transformers package version.
Guards deprecated imports in NeMo which were deleted in transformers >= 4.40

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

Signed-off-by: dimapihtar <[email protected]>

cuichenx

Thank you for making the change, this LGTM

cuichenx

could you resolve the CI issue? looks like there's an import problem

nemo/collections/nlp/modules/common/huggingface/huggingface_utils.py

Signed-off-by: dimapihtar <[email protected]>

Signed-off-by: Chen Cui <[email protected]>

Signed-off-by: Dmytro Pykhtar <[email protected]>

Signed-off-by: Chen Cui <[email protected]>

…dpykhtar/fix_transformers

Signed-off-by: cuichenx <[email protected]>

Signed-off-by: Chen Cui <[email protected]>

* unpin transformers Signed-off-by: dimapihtar <[email protected]> * guard deprecated imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * disable HF tests Signed-off-by: Dmytro Pykhtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Chen Cui <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: Chen Cui <[email protected]> Co-authored-by: Dmytro Pykhtar <[email protected]> Co-authored-by: cuichenx <[email protected]>

* unpin transformers Signed-off-by: dimapihtar <[email protected]> * guard deprecated imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * disable HF tests Signed-off-by: Dmytro Pykhtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Chen Cui <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: Chen Cui <[email protected]> Co-authored-by: Dmytro Pykhtar <[email protected]> Co-authored-by: cuichenx <[email protected]> Signed-off-by: Tugrul Konuk <[email protected]>

* unpin transformers Signed-off-by: dimapihtar <[email protected]> * guard deprecated imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * disable HF tests Signed-off-by: Dmytro Pykhtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Chen Cui <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: Chen Cui <[email protected]> Co-authored-by: Dmytro Pykhtar <[email protected]> Co-authored-by: cuichenx <[email protected]> Signed-off-by: tonyjie <[email protected]>

* unpin transformers Signed-off-by: dimapihtar <[email protected]> * guard deprecated imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * disable HF tests Signed-off-by: Dmytro Pykhtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Chen Cui <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: Chen Cui <[email protected]> Co-authored-by: Dmytro Pykhtar <[email protected]> Co-authored-by: cuichenx <[email protected]>

* unpin transformers Signed-off-by: dimapihtar <[email protected]> * guard deprecated imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * fix import guards Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * disable HF tests Signed-off-by: Dmytro Pykhtar <[email protected]> * try fixing Signed-off-by: Chen Cui <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * hard code model lists Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Chen Cui <[email protected]> Signed-off-by: Dmytro Pykhtar <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: Chen Cui <[email protected]> Co-authored-by: Dmytro Pykhtar <[email protected]> Co-authored-by: cuichenx <[email protected]> Signed-off-by: Hainan Xu <[email protected]>

dimapihtar added 2 commits July 3, 2024 08:29

unpin transformers

f46251f

Signed-off-by: dimapihtar <[email protected]>

guard deprecated imports

60d710a

Signed-off-by: dimapihtar <[email protected]>

dimapihtar requested a review from cuichenx July 3, 2024 15:39

github-actions bot added the NLP label Jul 3, 2024

Apply isort and black reformatting

ec435e5

Signed-off-by: dimapihtar <[email protected]>

dimapihtar added the Run CICD label Jul 3, 2024

cuichenx approved these changes Jul 3, 2024

View reviewed changes

cuichenx requested changes Jul 3, 2024

View reviewed changes

cuichenx reviewed Jul 3, 2024

View reviewed changes

nemo/collections/nlp/modules/common/huggingface/huggingface_utils.py Outdated Show resolved Hide resolved

dimapihtar and others added 3 commits July 3, 2024 11:36

fix import guards

59ed7f5

Signed-off-by: dimapihtar <[email protected]>

fix import guards

6643ebb

Signed-off-by: dimapihtar <[email protected]>

Merge branch 'main' into dpykhtar/fix_transformers

dea3ff8

dimapihtar requested a review from cuichenx July 3, 2024 18:38

dimapihtar added Run CICD and removed Run CICD labels Jul 3, 2024

Apply isort and black reformatting

5d89711

Signed-off-by: dimapihtar <[email protected]>

cuichenx added Run CICD and removed Run CICD labels Jul 3, 2024

try fixing

edf3971

Signed-off-by: Chen Cui <[email protected]>

cuichenx added Run CICD and removed Run CICD labels Jul 5, 2024

Dmytro Pykhtar and others added 2 commits July 5, 2024 12:29

disable HF tests

fc23a57

Signed-off-by: Dmytro Pykhtar <[email protected]>

Merge branch 'main' into dpykhtar/fix_transformers

efa319b

dimapihtar added Run CICD and removed Run CICD labels Jul 5, 2024

ericharper added Run CICD and removed Run CICD labels Jul 6, 2024

Merge branch 'main' into dpykhtar/fix_transformers

8b1c19c

cuichenx added Run CICD and removed Run CICD labels Jul 6, 2024

cuichenx added Run CICD and removed Run CICD labels Jul 9, 2024

dimapihtar added Run CICD and removed Run CICD labels Jul 9, 2024

Merge branch 'main' into dpykhtar/fix_transformers

f785b10

cuichenx added Run CICD and removed Run CICD labels Jul 9, 2024

cuichenx added 3 commits July 9, 2024 16:27

hard code model lists

a33a947

Signed-off-by: Chen Cui <[email protected]>

Merge remote-tracking branch 'origin/dpykhtar/fix_transformers' into …

8bf401e

…dpykhtar/fix_transformers

Merge branch 'main' into dpykhtar/fix_transformers

ef9811b

cuichenx added Run CICD and removed Run CICD labels Jul 9, 2024

cuichenx and others added 2 commits July 9, 2024 23:29

Apply isort and black reformatting

cfa1041

Signed-off-by: cuichenx <[email protected]>

hard code model lists

dbea3c1

Signed-off-by: Chen Cui <[email protected]>

cuichenx added Run CICD and removed Run CICD labels Jul 9, 2024

cuichenx changed the base branch from main to r2.0.0rc1 July 10, 2024 16:35

cuichenx changed the base branch from r2.0.0rc1 to main July 10, 2024 16:37

cuichenx approved these changes Jul 10, 2024

View reviewed changes

cuichenx merged commit b4821e1 into main Jul 10, 2024
203 checks passed

cuichenx deleted the dpykhtar/fix_transformers branch July 10, 2024 16:37

cuichenx mentioned this pull request Jul 10, 2024

Gemma 2 #9672

Merged

8 tasks

github-actions bot mentioned this pull request Jul 12, 2024

Gemma 2 #9708

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unpin transformers version #9606

unpin transformers version #9606

dimapihtar commented Jul 3, 2024

cuichenx left a comment

cuichenx left a comment

unpin transformers version #9606

unpin transformers version #9606

Conversation

dimapihtar commented Jul 3, 2024

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information

cuichenx left a comment

Choose a reason for hiding this comment

cuichenx left a comment

Choose a reason for hiding this comment