Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard cuda memory allocator update #9312

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Adds a try catch for torch cuda memory allocator for Lhotse

Collection: [ASR]

Changelog

  • Adds a guard with try catch to prevent hard crash under some older pytorch versions.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@titu1994 titu1994 merged commit 7235f2b into r2.0.0rc0 May 25, 2024
11 of 12 checks passed
@titu1994 titu1994 deleted the patch_caching_alocator branch May 25, 2024 00:09
github-actions bot pushed a commit that referenced this pull request May 25, 2024
* Guard cuda memory allocator update

Signed-off-by: smajumdar <[email protected]>

* Apply isort and black reformatting

Signed-off-by: titu1994 <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
titu1994 added a commit that referenced this pull request Jun 1, 2024
* Guard cuda memory allocator update



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* Guard cuda memory allocator update

* Apply isort and black reformatting

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
janekl pushed a commit that referenced this pull request Jun 12, 2024
* Guard cuda memory allocator update



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Guard cuda memory allocator update



* Apply isort and black reformatting



---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant