Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rope fusion default #8591

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ model:
bias_dropout_add_fusion: False # Use a kernel that fuses the bias addition, dropout and residual connection addition.
masked_softmax_fusion: True # Use a kernel that fuses the attention softmax with it's mask.
get_attention_mask_from_fusion: True # When using fused softmax it will create the attention mask so we won't copy it to the pipeline stages.
apply_rope_fusion: False # Use a kernel to add rotary positional embeddings. Only used if position_embedding_type=rope


# Miscellaneous
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ model:
bias_dropout_add_fusion: True # Use a kernel that fuses the bias addition, dropout and residual connection addition.
masked_softmax_fusion: True # Use a kernel that fuses the attention softmax with it's mask.
get_attention_mask_from_fusion: True # When using fused softmax it will create the attention mask so we won't copy it to the pipeline stages.
apply_rope_fusion: False # Use a kernel to add rotary positional embeddings. Only used if position_embedding_type=rope


# Miscellaneous
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ model:
bias_dropout_add_fusion: False # Use a kernel that fuses the bias addition, dropout and residual connection addition.
masked_softmax_fusion: True # Use a kernel that fuses the attention softmax with it's mask.
get_attention_mask_from_fusion: True # When using fused softmax it will create the attention mask so we won't copy it to the pipeline stages.
apply_rope_fusion: False # Use a kernel to add rotary positional embeddings. Only used if position_embedding_type=rope


# Miscellaneous
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ model:
bias_dropout_add_fusion: True # Use a kernel that fuses the bias addition, dropout and residual connection addition.
masked_softmax_fusion: True # Use a kernel that fuses the attention softmax with it's mask.
get_attention_mask_from_fusion: True # When using fused softmax it will create the attention mask so we won't copy it to the pipeline stages.
apply_rope_fusion: False # Use a kernel to add rotary positional embeddings. Only used if position_embedding_type=rope

# Miscellaneous
seed: 1234
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,8 @@ def build_transformer_config(self) -> TransformerConfig:

bias_dropout_fusion = self.cfg.get('bias_dropout_add_fusion', True)

apply_rope_fusion = self.cfg.get('apply_rope_fusion', True)
# @chcui default rope fusion to false until #8590 is closed.
apply_rope_fusion = self.cfg.get('apply_rope_fusion', False)
cuichenx marked this conversation as resolved.
Show resolved Hide resolved

# TODO: need to check if recompute APIs are matching up properly
recompute_granularity = self.cfg.get('activations_checkpoint_granularity', None)
Expand Down
Loading