Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rope fusion default #8591

Closed
wants to merge 2 commits into from
Closed

Change rope fusion default #8591

wants to merge 2 commits into from

Conversation

cuichenx
Copy link
Collaborator

@cuichenx cuichenx commented Mar 5, 2024

What does this PR do ?

Change rope fusion default as a workaround for #8590

@cuichenx cuichenx changed the base branch from main to r1.23.0 March 5, 2024 21:53
@cuichenx cuichenx requested a review from ericharper March 5, 2024 21:54
@cuichenx
add key to config files
9fef8d4 
Signed-off-by: Chen Cui <[email protected]>
@cuichenx cuichenx requested a review from ericharper March 5, 2024 22:52
ericharper
ericharper approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper
Copy link
Collaborator

jenkins

@ericharper
Copy link
Collaborator

Just noticed the base branch needs to be changed to main

@cuichenx
Copy link
Collaborator Author

cuichenx commented Mar 5, 2024

opened #8594 instead

@cuichenx cuichenx closed this Mar 5, 2024
@ericharper
Copy link
Collaborator

closed in favor of #8594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuichenx @ericharper