Use Mcore ModelParallelConfig in strategy parallelism property #11232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemildesai
requested review from
marcromeyn,
yaoyu-33,
JimmyZhang12,
maanug-nv and
akoumpa
hemildesai
force-pushed
the
hemil/use-model-parallel-config
branch
from
ffd8eb3
to
6ac5252
Compare
akoumpa
previously approved these changes
Nov 8, 2024
JimmyZhang12
previously approved these changes
Nov 8, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maanug-nv
previously approved these changes
Nov 8, 2024
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
hemildesai
force-pushed
the
hemil/use-model-parallel-config
branch
from
13bbea3
to
ef5131a
Compare
|
@hemildesai can you hold on this, I think my previous pr might get affected, since we are deleting encoder_pp_size and encoder_tp_size. #10643 |
marcromeyn
approved these changes
Nov 13, 2024
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Mcore's ModelParallelConfig directly in
strategy.parallelism. This should also enable backwards compatibility with different Mcore versions as it relies on the Mcore class now.