Add MCore FSDP2 support #11216
Open
Add MCore FSDP2 support #11216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasonwan <[email protected]>
Signed-off-by: jasonwan <[email protected]>
Signed-off-by: jasonwan <[email protected]>
Signed-off-by: blahBlahhhJ <[email protected]>
Signed-off-by: BoxiangW <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: BoxiangW <[email protected]>
Signed-off-by: BoxiangW <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
Signed-off-by: BoxiangW <[email protected]>
ericharper
reviewed
Nov 14, 2024
| @@ -193,6 +195,7 @@ def __init__( | |||
| ckpt_load_optimizer: bool = True, | |||
| ckpt_save_optimizer: bool = True, | |||
| ddp: Union[DDPLiteral, DistributedDataParallelConfig] = "megatron", | |||
| fsdp: bool = False, | |||
There was a problem hiding this comment.
should we rename it torch_fsdp because we know we'll have mcore_fsdp eventually?
There was a problem hiding this comment.
Do you think we can make this arg a string? ['mcore', 'torch'] or None.
Or expand this arg to fsdp defualts to false, and use_torch_fsdp defaults to false?
So:
fsdp=Ture, use_torch_fsdp=True -> torch_fsdp
fsdp=Ture -> mcore_fsdp (to be supported)
nothing -> ddp
Just trying to make the interface less confusing?
Signed-off-by: BoxiangW <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
| from megatron.core.distributed import TorchFullyShardedDataParallel as McoreTorchFSDP | ||
|
|
||
| HAVE_MCORE_TORCH_FSDP2 = True | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add MCore FSDP2 support
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information