-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slimpajama example #10671
base: main
Are you sure you want to change the base?
Add slimpajama example #10671
Conversation
e550dfe
to
645e9e2
Compare
a21ec4f
to
fac6acd
Compare
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
fac6acd
to
679379b
Compare
be0dcae
to
2ada689
Compare
Let's move notebooks to ./tutorials |
2ada689
to
a4f0517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completed the technical edit of the tutorials/llm/slimpajama/data_pipeline.ipynb and
tutorials/llm/slimpajama/pretraining.ipynb files and left comments. Please review the copyedits, make the changes to the source files, and resolve all open threads in the Reply field.
a4f0517
to
fba7d1d
Compare
I have made all the changes and resolved the threads, PTAL. |
fba7d1d
to
2bb1c8c
Compare
[🤖]: Hi @hemildesai 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Can we move this into the llama-3 folder, and add a README there with
Reference: https://github.com/NVIDIA/NeMo/tree/main/tutorials/llm/llama-3/biomedical-qa Does not have to be very comprehensive, just what the user needs to know/do to be able to run this. |
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"executor = docker_executor(host_data_path=\"/home/hemild/dev/data\")\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to remove PII like host_data_path here.
Keep this on a separate line with instructions to the user to configure this.
" shm_size=\"30g\",\n", | ||
" env_vars={\"PYTHONUNBUFFERED\": \"1\"},\n", | ||
" volumes=[f\"{host_data_path}:/data\"],\n", | ||
" container_image=\"python:3.11\",\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use the NeMo container to achieve all of this, to keep it simpler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This container is for downloading the data which doesn't use NeMo.
{ | ||
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this to a separate "Appendix" section with a subtitle "Running on SLURM"
Your previous command can be "Running Locally" to provide a visual indicator.
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
e9b31fc
to
dc304df
Compare
beep boop 🤖: 🚨 The following files must be fixed before merge! Your code was analyzed with PyLint. The following annotations have been identified:
Thank you for improving NeMo's documentation! |
@shashank3959 Addressed the comments in dc304df |
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information