Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slimpajama example #10671

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add slimpajama example #10671

wants to merge 16 commits into from

Conversation

hemildesai
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@hemildesai hemildesai marked this pull request as ready for review October 14, 2024 18:44
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@ericharper
Copy link
Collaborator

Let's move notebooks to ./tutorials

Copy link
Collaborator

@jgerh jgerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completed the technical edit of the tutorials/llm/slimpajama/data_pipeline.ipynb and
tutorials/llm/slimpajama/pretraining.ipynb files and left comments. Please review the copyedits, make the changes to the source files, and resolve all open threads in the Reply field.

@hemildesai
Copy link
Collaborator Author

I completed the technical edit of the tutorials/llm/slimpajama/data_pipeline.ipynb and tutorials/llm/slimpajama/pretraining.ipynb files and left comments. Please review the copyedits, make the changes to the source files, and resolve all open threads in the Reply field.

I have made all the changes and resolved the threads, PTAL.

Copy link
Contributor

[🤖]: Hi @hemildesai 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@shashank3959
Copy link
Collaborator

Can we move this into the llama-3 folder, and add a README there with

  • Pre-requisites / Requirements
  • Instructions to use the container
  • Start jupyter notebook.

Reference: https://github.com/NVIDIA/NeMo/tree/main/tutorials/llm/llama-3/biomedical-qa

Does not have to be very comprehensive, just what the user needs to know/do to be able to run this.

"metadata": {},
"outputs": [],
"source": [
"executor = docker_executor(host_data_path=\"/home/hemild/dev/data\")\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to remove PII like host_data_path here.

Keep this on a separate line with instructions to the user to configure this.

" shm_size=\"30g\",\n",
" env_vars={\"PYTHONUNBUFFERED\": \"1\"},\n",
" volumes=[f\"{host_data_path}:/data\"],\n",
" container_image=\"python:3.11\",\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use the NeMo container to achieve all of this, to keep it simpler?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This container is for downloading the data which doesn't use NeMo.

{
"cell_type": "markdown",
"metadata": {},
"source": [
Copy link
Collaborator

@shashank3959 shashank3959 Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this to a separate "Appendix" section with a subtitle "Running on SLURM"

Your previous command can be "Running Locally" to provide a visual indicator.

hemildesai and others added 16 commits December 3, 2024 17:42
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 4, 2024

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

@hemildesai
Copy link
Collaborator Author

@shashank3959 Addressed the comments in dc304df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants