Add reduction_unroll_factor to autotuning script #3487
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdspring1
added
the
Autotune
Support Gelu-Bias, Silu-Mul, Bcast-Add, Mul Fusions
rdspring1
force-pushed
the
autotune_inner_reduction_2d
branch
from
7817368 to
e7ffb29
Compare
rdspring1
force-pushed
the
autotune_inner_reduction_2d_update
branch
from
15bc05e to
fdcf6a5
Compare
liqiangxl
reviewed
Dec 2, 2024
| ) | ||
|
|
||
| # number of reduction elements not handled by a CTA | ||
| remaining_reduction = ceil_div( | ||
| num_reductions, | ||
| (scheduler_config.bdimx * scheduler_config.vectorize_factor), | ||
| (scheduler_config.bdimx * vectorize_factor * reduction_unroll_factor), |
There was a problem hiding this comment.
Should be ceil_div(ceil_div(num_reductions/vectorize_factor, bdimx), reduction_unroll_factor)
| ) | ||
|
|
||
| if unroll_factor == 1 and remaining_reduction > 1: | ||
| if iteration_unroll_factor == 1 and remaining_reduction > 1: |
There was a problem hiding this comment.
This looks strange to me. Why grdim = remaining_reduction? We can do serial reduction instread of grid reduction.
There was a problem hiding this comment.
nvFuser's default heuristic does:
// When iteration dim is small, may have unused SMs, to increase SM usage
// needs to shift from block reduction to grid reduction.
int64_t grdim = 1;
while (godim * grdim * 2 <= sm_count && getInnerRemainder() / grdim >= 2) {
grdim *= 2;
}
|
!build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
unroll_factortoiteration_unroll_factorand addsreduction_unroll_factor.reduction_unroll_factoradds unroll factor on top of vectorization factor for the inner reduction domain.