Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only check actually used IDs in predicate elimination for MmaOp #3414
Only check actually used IDs in predicate elimination for MmaOp #3414
Changes from 9 commits
9bf2645
96dd201
c7c790b
11083a1
11c43c4
683ae1e
c29470f
64be2c7
a9cc7aa
05d5ca4
5974567
e0ad380
3c2631f
3342e77
ee5329f
0cf29e5
381035f
732b873
60b23a3
9feb8f8
2f89ab4
6f451f7
9742b5b
9fb9aad
e623561
0660f8c
6e17d11
ee6a89a
2959d88
c41dec0
2693456
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose instead of using this we could possibly use
PredicatedChecker::isPredicated
instead. I kept it here to mirror the check in theAmpereSwizzle
test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is rather large, but since MmaOp is the only way I currently know how to trigger this behavior, I decided to just put the bulk of the test from #3406 here.