You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using clm for masking, it generates wrong masking schema.
It can be checked by following simple code.
In case of length 2 input, there should not be difference between last item only and all items conditions.
However, there is difference between them.
I've found my suggestion was wrong and already fixed. #723 (review)
However, from what I understand, the results is not correct. I reported it again according to the bug reporting format.
Description
When using
clm
for masking, it generates wrong masking schema.It can be checked by following simple code.
In case of length 2 input, there should not be difference between last item only and all items conditions.
However, there is difference between them.
Related Code
Transformers4Rec/transformers4rec/torch/masking.py
Line 298 in 348c963
I think following code is correct:
mask_labels = labels != self.padding_idx
The text was updated successfully, but these errors were encountered: