Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw an Internal Server error when trying to access a URL for which you don't have access #249

Open
1 task
adinuca opened this issue Jul 22, 2018 · 14 comments
Labels

Comments

@adinuca
Copy link
Contributor

adinuca commented Jul 22, 2018

Why

When a user that is not logged in tries to access a page for which he needs to be logged in, the application displayed a 500 error.
Example: https://www.resourcedata.org/user/followed_datasets/krystalsteel123 without being logged in.

What

  • a proper message is displayed to the user, or the user is redirected to login

Notes

At the moment, the user is shown an internal server error and there is a long stacktrace logged

@adinuca
Copy link
Contributor Author

adinuca commented Jul 22, 2018

Hi @EricSoroos , do you think we could handle this cases as well? I think that we should either show a Not Found page or Unauthorised or redirect the user to the login page.

@EricSoroos
Copy link
Collaborator

I'm sure it's possible. It should be a matter of catching the authorization exception and returning the appropriate response. It's done in other locations in ckan, so shouldn't be a big deal here. We're going to be talking about scheduling today, so I'll have a better idea of the timing after that conversation.

@adinuca
Copy link
Contributor Author

adinuca commented Aug 24, 2018

Hi @EricSoroos, any update on this?

@adinuca
Copy link
Contributor Author

adinuca commented Sep 7, 2018

Hi @deirdrelee , do you have an update on when this can be done? It has been flooding the logs lately and it is hard to spot real errors caused by actual problems.

@adinuca
Copy link
Contributor Author

adinuca commented Nov 5, 2018

Hi @EricSoroos, do you know if you will be able to handle this issue this year?

If not, could you give me some hints on how I could solve this?

Thank you!

@adinuca adinuca removed the Vitamin label Nov 25, 2019
@adinuca adinuca assigned cmovz and unassigned EricSoroos Feb 10, 2020
@adinuca
Copy link
Contributor Author

adinuca commented Feb 10, 2020

@cmovz , this is the repository : https://github.com/derilinx/ckan-docker-public
Take your time to understand how this works. Process is the same, create PR, merge on staging, deploy, test and then merge to master.

The URL for staging is https://staging.resourcedata.org/ and for production is https://resourcedata.org/

@cmovz
Copy link
Contributor

cmovz commented Feb 10, 2020

@adinuca I can't find ~/nrgi-resourcedata.org/ckan/config/solr/schema.xml

@cmovz
Copy link
Contributor

cmovz commented Feb 10, 2020

Do I have to sign up to SearchStax Free-Trial?

@adinuca
Copy link
Contributor Author

adinuca commented Feb 11, 2020

Do I have to sign up to SearchStax Free-Trial?

Why would you need this? You can use whatever is set up for Staging, but you might need to whitelist your IP in searchstax.

@adinuca
Copy link
Contributor Author

adinuca commented Feb 11, 2020

@adinuca I can't find ~/nrgi-resourcedata.org/ckan/config/solr/schema.xml

why do you need this?

@cmovz
Copy link
Contributor

cmovz commented Feb 11, 2020

The readme says to follow the steps on the guide, the first 3 steps are for configuring a SearchStax account, then proceed to copy the schema from that location to setup SOLR.

@adinuca
Copy link
Contributor Author

adinuca commented Feb 12, 2020

@cmovz , create a new deployment in SearchStax ( credentials are in 1password). Please use the cheapest version.

@adinuca
Copy link
Contributor Author

adinuca commented Feb 24, 2020

@cmovz , I will put these issues on hold for a while because I wasn't able to run the site either due to deprecated libraries and python versions.

@adinuca
Copy link
Contributor Author

adinuca commented Apr 13, 2020

This is on hold for now, we no longer have write permissions to the repo. Tommy is trying to find out what happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants