-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python sampler for residential #308
base: develop
Are you sure you want to change the base?
Conversation
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0aefb48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the thorough testing. Is this ready for primetime?
Rather than replacing the current ruby based sampler here, I'd prefer if you added a new sampler file and class. That way people can go back to the old one for a while during a transition period.
.github/workflows/ci.yml
Outdated
python-version: ['3.8', '3.9', '3.10'] | ||
python-version: ['3.10'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we only testing Python 3.10 now? I'd like to keep some level of backwards compatibility.
Pull Request Description
Python version of the sampling script. There are also helper testing script that can verify if a given buildstock.csv is correct or not according to the TSVs.
Use buildstockbatch normally, and it will use the faster python based sampler automatically for residential.
To use the sampler stand alone, a new command
resstock_sampler
can be used.There are two commands available
sample
to perform sampling, andverify
to verify existing buildstock.csv for correctness.Usage example:
resstock_sampler sample -p /Users/radhikar/Documents/resstock/project_national -o resstock_sampler_test.csv
resstock_sampler verify resstock_sampler_test.csv -p /Users/radhikar/Documents/resstock/project_national
Checklist
Not all may apply
minimum_coverage
in.github/workflows/ci.yml
as necessary.