define RNG seed for all dependencies #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 77.75% 77.75%
=======================================
Files 69 69
Lines 5481 5481
=======================================
Hits 4262 4262
Misses 1219 1219
Flags with carried forward coverage won't be shown. Click here to find out more.
|
daniel-thom
reviewed
Nov 11, 2024
| @@ -41,6 +41,8 @@ const CONSTANT = Float64 | |||
| const LIM_TOL = 1e-6 | |||
| const XY_COORDS = @NamedTuple{x::Float64, y::Float64} | |||
|
|
|||
| const RNG_SEED = get(ENV, "SIENNA_RNG_SEED", 2017) | |||
There was a problem hiding this comment.
Can you give an example of how setting the environment variable will be used? The value will be set the first time the code is compiled.
|
@daniel-thom I am trying to make something like this where we just need to define this once. It will be useful here and in PRASInterface.jl |
I'm still not following
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a constant for the random seed to be used by any RNG in the platform