Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add R-CMD workflow #159

Open
andybeet opened this issue Oct 18, 2024 · 7 comments · Fixed by #160
Open

add R-CMD workflow #159

andybeet opened this issue Oct 18, 2024 · 7 comments · Fixed by #160

Comments

@andybeet
Copy link
Member

andybeet commented Oct 18, 2024

Use workflow to ensure ecodata installs properly on all platforms.
Use to check for errors and warnings due to poorly specified functions

usethis::use_github_action()

@andybeet andybeet moved this to Backlog in State of the Ecosystem Oct 18, 2024
@andybeet andybeet linked a pull request Oct 18, 2024 that will close this issue
@andybeet andybeet changed the title add CRMD workflow add R-CMD workflow Oct 18, 2024
@sgaichas
Copy link
Member

sgaichas commented Oct 24, 2024

@andybeet @BBeltz1 I just noticed that the pull request into dev removing the workshop folder has actually removed some images that we reference in the SOEs and presentations.

For example, bottom_temp_threshold_17_19_Elephant_Trunk.png

See https://noaa-edab.github.io/presentations/20240530_SOE_Seminar_Beltz.html#38

This is currently in the main branch but that will also go away if dev goes into master/main.

This does not affect the printed/archived SOE pdfs but the image disappears from presentations if it was referenced at the dev link.

We still need a place for images that stay put somewhere in ecodata so they can be referenced across products.

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Oct 24, 2024

@sgaichas the workshop folder was relocated to the data-raw folder. Admittedly I'm not sure why this was necessary... maybe @andybeet can elaborate.

@sgaichas
Copy link
Member

Thanks for pointing that out Brandon, I missed that they were moved there. We will need to do a find in files and replace for the previous workshop/images references across the NOAA-EDAB org to ensure the images still show up where they have been included.

This is a good time to think through our design and ensure that whatever images folder we retain is in a place where it will be able to stay put.

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Oct 24, 2024

I agree

@andybeet
Copy link
Member Author

ah!! ok. well we can move them all back until we work out what to do (that would be the easiest)

@sgaichas
Copy link
Member

well I just changed the most recent one to reference master so it should still work, I'm not sure we need to revert everything just yet, especially if we want the CMD to work

@andybeet
Copy link
Member Author

if we reverted, i might be able to add the folder to the .buildignore to avoid the CMD issue. i could try that locally first. Sorry about this, thought workshop folder was orphaned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants