New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging for rust #340

Open

felixhekhorn opened this issue Jan 12, 2024 · 0 comments

Labels

rust

Contributor

felixhekhorn commented Jan 12, 2024 •

edited

Loading

This one might be the most delicate change, since it is actually affecting how we build the package.

However, we should just test once making a pseudo-tag locally (that is a proper tag, but avoiding pushing it) and building with pip wheel (that should be what we should use in the workflow, but we are not).
https://github.com/NNPDF/workflows/blob/818e8d74406df7c51992ea3b9377441a401a7087/.github/workflows/python-poetry-pypi.yml#L66-L69

So, updating the workflow with pip wheel (that should keep working for Poetry as well) is a requirement for merging this.

Originally posted by @alecandido in #189 (comment)

The text was updated successfully, but these errors were encountered:

felixhekhorn added the rust label

felixhekhorn mentioned this issue

Introduce Rust extension #189

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment