Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash computation seems not unique (across systems?) #267

Closed
felixhekhorn opened this issue May 15, 2023 · 2 comments
Closed

Hash computation seems not unique (across systems?) #267

felixhekhorn opened this issue May 15, 2023 · 2 comments
Labels
benchmarks Benchmark (or infrastructure) related bug Something isn't working

Comments

@felixhekhorn
Copy link
Contributor

The purpose of computing hashes inside banana is to boil down the full information to make it traceable - however, it seems that the hash is not unique across systems as was revealed in #241. At some point I had even locally the problem that the navigator comparison was empty, but the hash was still different.

For the case at hand we had:

  • ocard=cc12964 in the CI
  • - obs: 8beae75234d8ba49de7079e5f76d3916dd810708d31bb54f85505faf1c470055 locally for myself
  • - obs: 5d279b7c4222fc5f9b2858f7438e69a683a0030ea3a41c1093be921e2ae0f25b locally for @giacomomagni

something which just came to my mind: we might of course also depend on the Python version - however, that would not explain my local hickup ...

@felixhekhorn felixhekhorn added bug Something isn't working benchmarks Benchmark (or infrastructure) related labels May 15, 2023
@alecandido
Copy link
Member

I do not believe we actually depend on the Python version, since the hash function should be fixed.

However, this seems more of a banana issue rather than an eko/ekomark one.

@felixhekhorn
Copy link
Contributor Author

Agreed -> NNPDF/banana#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Benchmark (or infrastructure) related bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants