Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print metadata broken #25

Open
jesse-wei opened this issue Mar 31, 2023 · 1 comment
Open

Print metadata broken #25

jesse-wei opened this issue Mar 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jesse-wei
Copy link
Collaborator

Originated in commit 20009ed.

To reproduce,

git checkout 20009ed
./gui.py

Open an image and then Debug > Print metadata. It will display an empty dictionary.

Not a huge concern since we're not using sitk metadata for much. We use it to get units for a NIfTI file but it has never worked on NRRD.

Things like GetSize(), GetSpacing(), GetDirection() all work and those are useful.
jesse-wei referenced this issue Mar 31, 2023
@jesse-wei
Fixes, see description
20009ed 
#24 (review)

Fix code logic bugs where next, previous, and initial image (i.e., on open) were not oriented. Called orient_image in these specific functions. Could instead call orient_image in render_curr_slice to easily fix everywhere but feels inefficient.

Removed final instances of SMOOTH_BEFORE_RENDERING. curr_rotated_slice does not smooth, contour does smooth.
@jesse-wei jesse-wei added the bug Something isn't working label Apr 12, 2023
@jesse-wei
Copy link
Collaborator Author

Removed it from the menubar, but it's still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jesse-wei