Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reisdual drift method check in assessment.py #63

Open
ioannis-vm opened this issue Oct 17, 2024 · 0 comments
Open

Reisdual drift method check in assessment.py #63

ioannis-vm opened this issue Oct 17, 2024 · 0 comments

Comments

@ioannis-vm
Copy link
Contributor

I think it is not ideal to have this method check here. If anyone wants to add another method, they would need to extend the demand.estimate_RID and also come here and adjust the code. That seems unnecessary. We could do the prep work that is happening after the if statement regardless of the method chosen and then pass the residual_drift_inference dictionary to the estimate_RID method. That way, people can adjust the contents of that dictionary to the method of their choice and all of those can be handled inside the estimate_RID.

I don't think this needs to be taken care of immediately, but please create an issue with a note about this, so we do not forget to make the corresponding changes in the future.

Originally posted by @zsarnoczay in #51 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant