You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it is not ideal to have this method check here. If anyone wants to add another method, they would need to extend the demand.estimate_RID and also come here and adjust the code. That seems unnecessary. We could do the prep work that is happening after the if statement regardless of the method chosen and then pass the residual_drift_inference dictionary to the estimate_RID method. That way, people can adjust the contents of that dictionary to the method of their choice and all of those can be handled inside the estimate_RID.
I don't think this needs to be taken care of immediately, but please create an issue with a note about this, so we do not forget to make the corresponding changes in the future.
I think it is not ideal to have this method check here. If anyone wants to add another method, they would need to extend the demand.estimate_RID and also come here and adjust the code. That seems unnecessary. We could do the prep work that is happening after the if statement regardless of the method chosen and then pass the residual_drift_inference dictionary to the estimate_RID method. That way, people can adjust the contents of that dictionary to the method of their choice and all of those can be handled inside the estimate_RID.
I don't think this needs to be taken care of immediately, but please create an issue with a note about this, so we do not forget to make the corresponding changes in the future.
Originally posted by @zsarnoczay in #51 (comment)
The text was updated successfully, but these errors were encountered: