Convert Shortcode model in admin.js

[eswarsaladi]

Code :

drs-toolkit-wp-plugin/assets/js/admin.js

Lines 54 to 84 in 9972f37

	drstk.Shortcode = Backbone.Model.extend({
	defaults: {
	type: '',
	items: new drstk.Items(),
	settings: new drstk.Settings(),
	colorsettings: new drstk.ColorSettings(),
	},
	initialize: function () {
	this.set('items', new drstk.Items());
	this.set('settings', new drstk.Settings());
	this.set('colorsettings', new drstk.ColorSettings());
	},
	parse: function (response) {
	response.items = new drstk.Items(response.items);
	response.settings = new drstk.Settings(response.settings);
	response.colorsettings = new drstk.ColorSettings(response.colorsettings);
	return response;
	},
	set: function (attributes, options) {
	if (attributes.items !== undefined && !(attributes.items instanceof drstk.Items)) {
	attributes.items = new drstk.Items(attributes.items);
	}
	if (attributes.settings !== undefined && !(attributes.settings instanceof drstk.Settings)) {
	attributes.settings = new drstk.Settings(attributes.settings);
	}
	if (attributes.colorsettings !== undefined && !(attributes.colorsettings instanceof drstk.ColorSettings)) {
	attributes.colorsettings = new drstk.ColorSettings(attributes.colorsettings);
	}
	return Backbone.Model.prototype.set.call(this, attributes, options);
	},
	});

Tasks :

• Refactor Shortcode model
• Comment each function inside the model

Estimated Time: 20 - 30 min

[patrickmj]

In particular, this will help make the code more clear about the 6 different kinds of shortcodes at work in old CERES. That'll be important to have in place for managing the upcoming changeover to new CERES, and will intersect with some of Aadesh's work very soon.