Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor admin.js for readability and modernization #260

Open
1 of 3 tasks
patrickmj opened this issue Jun 14, 2023 · 0 comments
Open
1 of 3 tasks

Refactor admin.js for readability and modernization #260

patrickmj opened this issue Jun 14, 2023 · 0 comments
Assignees
Milestone

Comments

@patrickmj
Copy link
Member

patrickmj commented Jun 14, 2023

Old admin.js needs to be refactored so all the individual pieces are coherent and findable.

It's in Backbone, but that will eventually be removed. To maintain backward compatibility during our upgrades, it will need to remain a Backbone app. However, within each method there is plenty of work to do. Functionality should not change or be visible to end users, but the code quality will be deeply improved.

You will see:

  • long if...then...else chains that could be consolidated
  • semantically meaningless variables and names, e.g. if tab == 1, where 1 doesn't really say what it is
  • 7 + year old javascript
  • opportunities for further modularization
  • and more

Focus on the following in admin.js, and make changes anywhere else necessary to make them work as needed.

@patrickmj patrickmj added this to the JS refactor milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants