Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the IMU's mscl library #95

Open
harshil21 opened this issue Nov 20, 2024 · 5 comments
Open

Upgrade the IMU's mscl library #95

harshil21 opened this issue Nov 20, 2024 · 5 comments

Comments

@harshil21
Copy link
Member

harshil21 commented Nov 20, 2024

https://github.com/LORD-MicroStrain/MSCL/releases/tag/v66.0.0.

Needs major testing with IMU since the timestamp field is now no longer the unix epoch.

@harshil21 harshil21 converted this from a draft issue Nov 20, 2024
@harshil21 harshil21 changed the title Consider upgrading the IMU's mscl library - https://github.com/LORD-MicroStrain/MSCL/releases/tag/v66.0.0. Needs major testing with IMU since the timestamp field is now no longer the unix epoch. Upgrade the IMU's mscl library Nov 20, 2024
@JacksonElia
Copy link
Member

I don't know if this is a great idea because 1. it might be a lot of work, and do we get anything out of it?
2. Our imu is already old as hell so there could be some potential compatibility issues idk

@wlsanderson
Copy link
Contributor

From the changes you linked:
"Moved Quaternion class to EulerAngles.h, added Rotation class to represent either a Quaternion or EulerAngles object"

Does that just mean that it wont be able to output quaternions anymore and it will just give euler angles?

@harshil21
Copy link
Member Author

From the changes you linked: "Moved Quaternion class to EulerAngles.h, added Rotation class to represent either a Quaternion or EulerAngles object"

Does that just mean that it wont be able to output quaternions anymore and it will just give euler angles?

Not really, it just means that they have a single class which can be a Quaternion or EulerAngles. Similar to how we have a IMUDataPacket which can be Raw or Est. https://lord-microstrain.github.io/MSCL/Documentation/MSCL%20Documentation/index.html#File:MicroStrain/Inertial/EulerAngles.h:Quaternion

I don't know if this is a great idea because 1. it might be a lot of work, and do we get anything out of it? 2. Our imu is already old as hell so there could be some potential compatibility issues idk

we can very easily just downgrade it if something doesn't work out

@JacksonElia
Copy link
Member

Wait though what is the benefit of doing this? Seems kinda painful and does it actually get us anything nice? E.g. is it faster somehow?

@harshil21
Copy link
Member Author

There is no reason to not upgrade, e.g. it has fixes and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo if we have time
Development

No branches or pull requests

3 participants