Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to generate datasets #63

Open
wlsanderson opened this issue Oct 27, 2024 · 1 comment · May be fixed by #76
Open

Add functionality to generate datasets #63

wlsanderson opened this issue Oct 27, 2024 · 1 comment · May be fixed by #76
Labels
enhancement New feature or request

Comments

@wlsanderson
Copy link
Contributor

wlsanderson commented Oct 27, 2024

With the upcoming changes of adding apogee prediction, and a dynamic way to identify the vertical direction using the gravity vector, the ability to test these features is important. Due to the lack of valid datasets to use, I think it would be worthwhile to add a parameter to the mock sim to assign what the vertical direction is, and rotate the dataset accordingly.

To implement this, I'm not sure the best approach. I don't think we should have 6 different csv's for each datasets. I think a parameter would have to be passed in the data processor that has the desired vertical axis, and it would have to be compared with the initial gravity vector to find what quaternion to rotate all of the acceleration and gyro data by.

Any advice on the broader implementation process would be great.

EDIT: the goal is now to fully generate datasets, not just rotate them

@wlsanderson wlsanderson added the enhancement New feature or request label Oct 27, 2024
@wlsanderson wlsanderson mentioned this issue Oct 27, 2024
@harshil21
Copy link
Member

Yeah, this ties into the general need for us to be able to generate and simulate any flight, given a set of initial conditions and desired outcomes (e.g. different apogee, different acceleration profile, etc)

Regarding orientations specifically, we could do that feature before generating the rest of the flight data, since this is just a subset of that feature, and it doesn't quite change the flight profile.

However, the correct way to approach this is to first do this in the unit tests first, since we can generate arbitrary data packets and test small components of the entire system, and then we can think of upgrading our mock sim.

@wlsanderson wlsanderson linked a pull request Nov 5, 2024 that will close this issue
@wlsanderson wlsanderson changed the title Add functionality to rotate datasets Add functionality to generate datasets Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants