Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More easy tasks #38

Open
1 of 6 tasks
JacksonElia opened this issue Oct 4, 2024 · 2 comments
Open
1 of 6 tasks

More easy tasks #38

JacksonElia opened this issue Oct 4, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@JacksonElia
Copy link
Member

JacksonElia commented Oct 4, 2024

  • Make landed state trigger properly (you can see in the graph on the readme, it triggers prematurely while the rocket is still falling) Attempted fix for landed state detection #59
  • Fix/Improve/Add unit tests (the more good quality ones, the better)
  • Find any places in the code that need to be commented better (if you don't understand it after thinking through it moderately hard, it's not good enough)
  • Find any variable, method, or class names that need to be improved (naming is key, maybe some names don't make sense right away)
  • Comment our test code
  • Make enum and constant for speed to use for which orientation the rocket is in
@JacksonElia JacksonElia added the good first issue Good for newcomers label Oct 4, 2024
@harshil21
Copy link
Member

harshil21 commented Oct 4, 2024

  • Make landed state trigger properly (you can see in the graph on the readme, it triggers prematurely while the rocket is still falling)

You mean to just change the constant at which it landedstate is triggered? Right now it considers it landed if it's within 15m of the launch site's height. Set it too low, and it might not trigger if it lands at an higher elevation. Set it too high, and it triggers too early. IMO we can go down 7m, but then again I don't know the launch site topography at Huntsville.

Ideally we would also check the speed and/or acceleration (zero)

@JacksonElia
Copy link
Member Author

Yeah I wouldn't just change the constant, probably also do something based on accel -- that being said, it's up to whoever does this to test it against multiple data sets and what not to ensure it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants