Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that prevents "https://" netCDF files from being read #269

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

davidhassell
Copy link
Contributor

Fixes #268

@davidhassell davidhassell added the bug Something isn't working label Aug 30, 2023
@davidhassell davidhassell added this to the 1.10.1.2 milestone Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #269 (8860191) into main (142accf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   87.35%   87.36%   +0.02%     
==========================================
  Files         125      125              
  Lines       12887    12887              
==========================================
+ Hits        11256    11258       +2     
+ Misses       1631     1629       -2     
Flag Coverage Δ
unittests 87.36% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cfdm/read_write/netcdf/netcdfread.py 83.64% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bewithankit bewithankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked with another OPeNDAP URL and it works:

>>> import cfdm
>>> j = cfdm.read('https://dapds00.nci.org.au/thredds/dodsC/zv2/agcd/v2-0-1/precip/total/r005/01month/agcd_v2-0-1_precip_total_r005_monthly_1900.nc')
[<Field: lwe_thickness_of_precipitation_amount(time(12), latitude(691), longitude(886)) mm>]

Thank you David. Merge when ready!

@davidhassell davidhassell merged commit e13ec51 into NCAS-CMS:main Aug 30, 2023
4 of 13 checks passed
@davidhassell davidhassell deleted the read-https branch August 30, 2023 09:53
@davidhassell davidhassell added the netCDF read Relating to reading netCDF datasets label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working netCDF read Relating to reading netCDF datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading https:// netCDF files does not work
2 participants