Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too many property widgets! #106

Open
bradfordcondon opened this issue Dec 13, 2018 · 4 comments
Open

too many property widgets! #106

bradfordcondon opened this issue Dec 13, 2018 · 4 comments

Comments

@bradfordcondon
Copy link
Contributor

solutions:

Put widget in a fieldset.

use feature_cvterm instead

@almasaeed2010
Copy link
Contributor

can't use _cvterm because we need a term and a value

Maybe Tripal shouldn't auto create fields for props like it currently does and allows developers/admins to choose which fields to create. If that was true, we could design our own field to handle the props differently. Should we take this to core?

@bradfordcondon
Copy link
Contributor Author

i'd definitely like to raise the issue in core, citing that this module will create up to 500 biosample properties because thats what NCBI defines.

two distinct problems, too- cluttering hte input form, and cluttering the admin area

@almasaeed2010
Copy link
Contributor

almasaeed2010 commented Dec 14, 2018

make that 3 since the queries will be executed in all biosample pages although not all will have values for the 500 fields (unless I am misunderstanding something). If this is true, it'd make our biosample pages very slow.

@bradfordcondon
Copy link
Contributor Author

they wont have field instances attached unless theyre populated so i dont believe it would fire a query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants