Need to test jquery 3.3.1

[childers]

The version of jquery we're using now has security issues, and we'll need to update it before any more deployments.

[deming7h777]

Except for travis CI, can you give me some tips for testing jquery3.3.1 ?

[hsiaoyi0504]

You need to test it manually ... We don't have many automatic UI testing.

[childers]

https://jquery.com/upgrade-guide/3.0/#jquery-core-3-0-upgrade-guide
They have an upgrade plan with some helper scripts to identify deprecated code.

[hsiaoyi0504]

As far as I know, the challenging part is not itself, but other javascript libraries use it.

[deming7h777]

https://github.com/jquery/jquery-migrate/#README
https://github.com/jquery/jquery-migrate/tree/1.x-stable#readme
https://github.com/jquery/jquery-migrate/blob/1.x-stable/warnings.md

now i 'm trying to use these two plugin to update our version form 1.11.1 to 3.3.1 without bugs

[deming7h777]

I fixed the function of loading the example data

[hsiaoyi0504]

Any update of this ?

[deming7h777]

After testing in my local site, I think jquery 3.3.1 is available for genomics-workspace
But I am not sure that every detail of this project has been tested.

[hsiaoyi0504]

Do you push that to a new branch ? I can test that a little bit more and make CI tests it as well.

[childers]

@deming7h777 I thought this was on a branch. Is it just on your local?

[deming7h777]

I have push it to npminstallDAP branch.
As far as the tests are currently done, it seems that all functions are normal.

[hsiaoyi0504]

@deming7h777 please push to this repo, rather than our customized one. At the same time, don’t push that to branch that have a pull request for other stuff. It may be merged accidentally.

[deming7h777]

Initially, we update to jquery3.3.1 because we want to install DAP code via npm, and only customized one need it .
Should I push to genomics-workspaces rather than NAL-genomicsworkspace ?

[hsiaoyi0504]

What ? It seems to me they are two different things. jQuery 3.x is not a requirement of DAP. However, we still hope to update to jQuery 3.x because either npm or github report that there is a security vulnerability of jQuery 1.x.

[hsiaoyi0504]

At the same time, the update of jQuery should be introduced to our general version as well, but DAP is only for our customized version.

[deming7h777]

I know it's different things but we update jquery 3.3.1 due to some vulnerability initially so I think we still need to update it either general version and customized version .
or just general one?

[hsiaoyi0504]

How we update both of the general and customized repos is by

1. update the general one first
2. use git merge to introduce many features we made on general repo into customized version

[hsiaoyi0504]

Keeping only one feature update in one pull request makes us track the progress of each pull request easier.

[hsiaoyi0504]

Will be finished by #256.