Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencer - Use of editor as dependency in non-editor targets #21

Open
mateuszwojt opened this issue Nov 29, 2022 · 2 comments
Open

Sequencer - Use of editor as dependency in non-editor targets #21

mateuszwojt opened this issue Nov 29, 2022 · 2 comments

Comments

@mateuszwojt
Copy link
Contributor

I'm building the plugin using command-line tools (UAT) for "reasons", which unfortunately triggers a lot of errors and warnings. This doesn't happen when compiling with Visual Studio

In my case, the build fails because the StableDiffusionSequencer module is using UnrealEd as one of the dependencies, even though it's a runtime module. I'm getting the following error:

Unable to instantiate module 'UnrealEd': Unable to instantiate UnrealEd module for non-editor targets.
(referenced via Target -> StableDiffusionSequencer.Build.cs)

My workaround was changing it from Runtime to the deprecated Developer type, but this is not ideal of course. I'm not sure what should be the correct approach here. I found that issue in some other plugins, like DLSS.

@Mystfit
Copy link
Owner

Mystfit commented Nov 29, 2022

I split the Sequencer into editor and runtime modules to try and tackle exactly this sort of issue but it seems as though that dependency has hung around for some reason. I'll try and remove it from the runtime sequencer module and see what that breaks.

@Mystfit
Copy link
Owner

Mystfit commented Jan 6, 2023

Sorry that this has taken me a while to get around to. I'm experimenting making sure editor modules are only compiled in the editor. Would you be able to add the following code to StableDIffusionSequencer.Build.cs and remove the existing UnrealEd and EditorFramework references from PrivateDependencyModuleNames?

if (Target.bBuildEditor){
    PrivateDependencyModuleNames.AddRange(new string[]{
        "UnrealEd",
        "EditorFramework"
    });
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants