Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestingScreen idle override should be registered to the Skill that called it #58

Open
krisgesling opened this issue Feb 18, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@krisgesling
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Overriding the idle screen from a Skill doesn't track which Skill created the override. Hence it would be possible for multiple Skills to be acting on the RestingScreen and interfering with each other.

Example:

  1. Skill A is triggered, performing some action
  2. Skill B is triggered and overrides idle
  3. Skill A finishes and clears it's namespace
  4. Skill B's idle override gets unintentionally cancelled by Skill A releasing the override

Describe the solution you'd like
Skills should only be able to perform actions on their own idle screen.
Need to look at how we handle multiple Skills wanting to be the idle screen. Currently a new one overrides an older one. Should it be a stack where Skills can clear their item in the stack, but if they haven't clearing all above would return to that?

Additional context
Arose from this discussion.

@krisgesling krisgesling added the enhancement New feature or request label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant