Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching in multiple, selected tables (inclusion and exclusion). #37

Open
RokeJulianLockhart opened this issue Jun 3, 2024 · 7 comments

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jun 3, 2024

Use cases

Like in most desktop file managers, consider checkboxes prepended to list entries, with an "all" entry above them:

  1. Sometimes, which table a known key is stored within isn't known, meaning that the user must choose each table and attempt the query individually. This isn't feasible with the amount of tables individually exposed:

    Screenshot_20240603-184410

    I'd consequently like to be able to select the tables to search across, to include them.

  2. Additionally, sometimes I want to search solely within a few specific tables to ensure that a key or value is within them. To accomplish this, I would like to be able to exclude certain tables.

@MuntashirAkon
Copy link
Owner

I've thought about it too. But the way the feature was implemented, it's not possible to implement such a functionality in a simple way. It's probably possible to merged the first three tables into one in order to make it easier to search across the settings.

@gstjee
Copy link

gstjee commented Sep 7, 2024

It's probably possible to merged the first three tables into one....

I think other best option would atleast keep searched keyword in search box and then user can switch between tables to see anything found. currently it resets search bar when we switch between tables which extremely annoying when searched string is long.
I feel this is only thing which is missing except that app is perfect.

@RokeJulianLockhart
Copy link
Author

#37 (comment)

@gstjee, that would be useful too, but when searching for multiple keywords, I would like what I've proposed too.

@gstjee
Copy link

gstjee commented Sep 7, 2024

yeah, if it is feasible for developer then first method is more usefull with little more enhancements like:
resulted tables: should be displayed with their table name and also individual tables should be separated from one another in view window.
Edit: because sometime power user just not only want to edit the value but also wants to know in which table that key pair exists for various his other use cases.

@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Sep 7, 2024

#37 (comment)

@gstjee, there is use for what you've proposed, though - being able to dynamically include tables necessarily necessitates that the user be able to exclude tables too. This would be useful when ascertaining whether a key or value exists in multiple tables. I'll try to re-scope the issue to include your proposal.

because sometime power user just not only want to edit the value but also wants to know in which table that key pair exists for various his other use cases.

Were the search to result in a tabled view, with a column for the database in which the key or value resides, this would be easily discernable.

@RokeJulianLockhart RokeJulianLockhart changed the title Search across tables. Allow searching in multiple, selected tables (inclusion and exclusion). Sep 7, 2024
@gstjee
Copy link

gstjee commented Sep 7, 2024

@RokeJulianLockhart i guess exclusion inclusion of tables in searched results could leads to complex code which i guess @MuntashirAkon won't wants that. may be i am wrong but he wants things in simple and less complex manner.

so i would suggest just keep it simple like:
after searching keyword then results should be displayed in below manner in view:


System Table:
rows if there is any

Secure Table:
rows if there is any

so on for all tables . if any table doesn't have searched key then don't show its heading as well.


@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Sep 7, 2024

#37 (comment)

@gstjee, I've considered that. However, this would actually be less spaghettified - implementing the search in such a way that it's designed to include and exclude datasets would be the more consistent implementation, because searching across tables isn't implemented as an exception. Instead, it would merely be possibility of many, as a consequence of a more broadly robust method.

Otherwise, this functionality shall be subsequently proposed by someone, and then it'll be implemented as an edge case too, when we could have refactored it more comprehensively initially.

I'll leave the developer to assess what methods of implementation are feasible due to code debt and complexity, whilst we focus upon what's the best UX for the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants