Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to enable DataFramesNotEqualError to be raised without printing the differences between the two dataframes #43

Open
slavyolov opened this issue Mar 9, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@slavyolov
Copy link

When calling the assert_df_equality and assert_approx_df_equality it will be good to have the option to not display the get_string(). Sometimes the output might be to long or truncated.I think this could be a good addition.

image

Example of the idea:

DataFramesNotEqualError("\n" + t.get_string()) if full_log else DataFramesNotEqualError

Where full_log is boolean 
@MrPowers
Copy link
Owner

MrPowers commented Mar 9, 2022

@slavyolov - thanks for opening the issue. I'm open to the suggestion, but not entirely sure I understand how the output will be different. Can you open a PR and show the output when full_log is true and the output when full_log is false, so I can better understand? Thanks!

@MrPowers MrPowers added the good first issue Good for newcomers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants