Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore_column_order param for assert_approx_df_equality function #38

Open
fraserpal opened this issue Jan 27, 2022 · 3 comments
Open

ignore_column_order param for assert_approx_df_equality function #38

fraserpal opened this issue Jan 27, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@fraserpal
Copy link

It would be great if we could avoid column order checking when using assert_approx_df_equality
@fraserpal fraserpal changed the title ignnore_column_order for assert_approx_df_equality function ignore_column_order param for assert_approx_df_equality function Jan 27, 2022
@fraserpal
Copy link
Author

same applies for ignore_row_order

@fraserpal fraserpal changed the title ignore_column_order param for assert_approx_df_equality function ignore_column_order param for assert_approx_df_equality function Jan 27, 2022
@MrPowers
Copy link
Owner

MrPowers commented Feb 9, 2022

@fraserpal - thanks for the suggestion, sounds like a good idea. Would you like to send a PR?

@fraserpal
Copy link
Author

fraserpal commented Feb 15, 2022 •
edited
Loading

open PR, @MrPowers

@MrPowers MrPowers added the good first issue Good for newcomers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrPowers @fraserpal