Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify columns to ignore for assert_df_equality #140

Open
kasztp opened this issue Oct 4, 2024 · 0 comments
Open

Add option to specify columns to ignore for assert_df_equality #140

kasztp opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kasztp
Copy link
Contributor

kasztp commented Oct 4, 2024

Is your feature request related to a problem? Please describe.

Often when comparing dataframes we have some columns which can / should be ignored during the equality check. E.g. timestamp columns, or UUID.

Describe the solution you would like

Add a new optional parameter to assert_df_equality() function, where the user can specify the names of columns to ignore during comparsion.

Additional context

Technical solution could be either:

  1. Dropping the specified columns from the dataframes before comparing them,
  2. Extending all relevant comparsion functions to take this setting into account.

The first solution is doable with minimal code, and without affecting the rest of the functions.

Are you planning on creating a PR?

  • [ x ] I'm planning to make a pull-request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant