Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fullscreen video environment dim is lighter than Private Browsing environment dim #861

Closed
cvan opened this issue Nov 28, 2018 · 1 comment
Labels
wontfix resolved: this will not be worked on (to be set by module owners or module peers only)
Milestone

Comments

@cvan
Copy link
Contributor

cvan commented Nov 28, 2018

Hardware

Oculus Go
9e66e70

Steps to Reproduce

  1. Open Private Browsing mode (from the Tray).
  2. Notice the opacity of the environment dim.
  3. Launch https://webxr.sh/media.
  4. Open test case #5.
  5. Press the Fullscreen icon on the <video controls> element.
  6. Notice the opacity of the environment dim becomes lighter than the dim of the environment when Private Browsing mode is engaged outside of Fullscreen Mode.

Current Behavior

The opacity of the environment dim becomes lighter than the dim of the environment when Private Browsing mode is engaged outside of Fullscreen Mode.

Expected Behavior

The opacity of the environment dim becomes darker than the dim of the environment when Private Browsing mode is engaged outside of Fullscreen Mode.

Possible Solution

Possibly add more purple too.

Context

See these related issues:

@cvan cvan added enhancement This issue is a new feature or request backlog P3 Backlog labels Nov 28, 2018
@caseyyee caseyyee added the UX Issue relates to UX label Nov 28, 2018
@cvan
Copy link
Contributor Author

cvan commented Nov 29, 2018

FWIW, I discovered today that Oculus Browser does the same exact thing (unless you manually change the Fullscreen Controls' Brightness settings to the Darkest mode). Heh.

We should still fix this. But I found it interesting. And it made me realise we should probably take into account the following dims from:

  1. Private Browsing dim +
  2. Fullscreen dim +
  3. Brightness (via Fullscreen Controls) dim

Oh, and a dim for a (FxR-level) Permission Prompt when one appears (probably during Private Browsing, or could happen during a Pointer-Lock + Fullscreen session).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix resolved: this will not be worked on (to be set by module owners or module peers only)
Projects
None yet
Development

No branches or pull requests

4 participants