Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title, Description, Image missing #10

Open
shtefcs opened this issue May 10, 2018 · 2 comments
Open

Title, Description, Image missing #10

shtefcs opened this issue May 10, 2018 · 2 comments
Labels
bug Something isn't working enhancement enhance or fix investigate This doesn't seem right

Comments

@shtefcs
Copy link
Contributor

shtefcs commented May 10, 2018

Many times I came across empty title, description, image in Moonly Extension, while the page have both Title/Description meta tags and OG tags aswell.

Here is example to investiagate:

url:https://www.wanderingaimfully.com/blog/challenges

Source of page:


<title>The Challenges of Building Something Won't Get Us Down — Wandering Aimfully </title>
--
  | <link rel="shortcut icon" type="image/x-icon" href="https://static1.squarespace.com/static/5aa1a6cc5ffd2017e8cc379c/t/5ab6d12cf950b7f8f14d6bab/favicon.ico"/>
  | <link rel="canonical" href="https://www.wanderingaimfully.com/blog/challenges"/>
  | <meta property="og:site_name" content="Wandering Aimfully "/>
  | <meta property="og:title" content="The Challenges of Building Something Won't Get Us Down"/>
  | <meta property="og:latitude" content="40.7207559"/>
  | <meta property="og:longitude" content="-74.00076130000002"/>
  | <meta property="og:url" content="https://www.wanderingaimfully.com/blog/challenges"/>
  | <meta property="og:type" content="article"/>
  | <meta property="og:description" content="We’ve been tested and challenged more than ever these past few weeks, both by business and life stuff. But we’re handling it the only way we know how: as a team."/>
  | <meta property="og:image" content="http://static1.squarespace.com/static/5aa1a6cc5ffd2017e8cc379c/5aa1aa3724a6947560967ff9/5aef746d352f535b34de90a5/1525742903577/challenges-min.png?format=1000w"/>
  | <meta property="og:image:width" content="1000"/>
  | <meta property="og:image:height" content="750"/>
  | <meta itemprop="name" content="The Challenges of Building Something Won't Get Us Down"/>
  | <meta itemprop="url" content="https://www.wanderingaimfully.com/blog/challenges"/>
  | <meta itemprop="description" content="We’ve been tested and challenged more than ever these past few weeks, both by business and life stuff. But we’re handling it the only way we know how: as a team."/>
  | <meta itemprop="thumbnailUrl" content="http://static1.squarespace.com/static/5aa1a6cc5ffd2017e8cc379c/5aa1aa3724a6947560967ff9/5aef746d352f535b34de90a5/1525742903577/challenges-min.png?format=1000w"/>
  | <link rel="image_src" href="http://static1.squarespace.com/static/5aa1a6cc5ffd2017e8cc379c/5aa1aa3724a6947560967ff9/5aef746d352f535b34de90a5/1525742903577/challenges-min.png?format=1000w" />
  | <meta itemprop="image" content="http://static1.squarespace.com/static/5aa1a6cc5ffd2017e8cc379c/5aa1aa3724a6947560967ff9/5aef746d352f535b34de90a5/1525742903577/challenges-min.png?format=1000w"/>
  | <meta name="twitter:title" content="The Challenges of Building Something Won't Get Us Down"/>
  | <meta name="twitter:image" content="http://static1.squarespace.com/static/5aa1a6cc5ffd2017e8cc379c/5aa1aa3724a6947560967ff9/5aef746d352f535b34de90a5/1525742903577/challenges-min.png?format=1000w"/>
  | <meta name="twitter:url" content="https://www.wanderingaimfully.com/blog/challenges"/>
  | <meta name="twitter:card" content="summary"/>
  | <meta name="twitter:description" content="We’ve been tested and challenged more than ever these past few weeks, both by business and life stuff. But we’re handling it the only way we know how: as a team."/>
  | <meta name="description" content="We’ve been tested and challenged more than ever these past few weeks, both
  | by business and life stuff. But we’re handling it the only way we know how:
  | as a team." />


@shtefcs shtefcs added bug Something isn't working enhancement enhance or fix investigate This doesn't seem right labels May 10, 2018
@shtefcs
Copy link
Contributor Author

shtefcs commented Jul 5, 2018

@shtefcs
Copy link
Contributor Author

shtefcs commented Jul 5, 2018

Moonly: https://imgur.com/Z3Tgb2j
Facebook OG Preview: https://i.imgur.com/Wvxqqj5.png

I think it should work this way.

When the page is shared with Moonly Extension, extension should directly check in source code the OG's.

If the OG is not available, check the meta Title and Meta description.
If that fail to, use callback etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement enhance or fix investigate This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant