Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counting starts from 0 or 1? #13

Closed
tovrstra opened this issue Aug 18, 2017 · 4 comments
Closed

Counting starts from 0 or 1? #13

tovrstra opened this issue Aug 18, 2017 · 4 comments

Comments

@tovrstra
Copy link
Contributor

When refering to array elements, e.g. an atom or a center index, we should decide that counting starts either from 0 (please) or 1 (noooo). Some is already mentioned here: Technical_Specifications.md

For example, it is relevant to #12.

@dgasmith
Copy link
Collaborator

Agreed, count from zero! I wonder how that translates to Fortran JSON parsers. @wadejong any comments?

@dgasmith
Copy link
Collaborator

@tovrstra Where do you think the best place to put this information is, in a FAQ?

@tovrstra
Copy link
Contributor Author

Mentioning it in the FAQ is certainly helpful but we should probably also have a more formal definition of such rules. I'm not very familiar with JSON Schema. If we eventually write out such a schema, which would facilitate validation, it can also be fixed formally, see e.g. http://json-schema.org/examples.html

@cryos
Copy link
Collaborator

cryos commented Aug 30, 2017

I think starting from 0 makes sense, JSON arrays generally do this. It should go in the FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants