Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type inconsistencies and stop using archaic intrinsic functions #29

Open
RBCanelas opened this issue Feb 1, 2019 · 0 comments
Assignees
Labels

Comments

@RBCanelas
Copy link
Contributor

Compiling Base1 & Base2 with GNU Fortran (GFortran) with naive compiler flags renders a list of errors related to type mismatches. Example:

ModuleFunctions.F90:6230:25:
aux1 = dmod (aux, DTD)
1
Error: 'a' argument of 'dmod' intrinsic at (1) must be double precision

ModuleFunctions.F90:6231:33:
MinError = min (dabs(aux1), dabs(DTD - aux1))
1
Error: 'a' argument of 'dabs' intrinsic at (1) must be double precision

These are related to the use of dabs and dmod, that shouldn't be used (using abs and mod is enough).

ModuleVoronoi3D.f:71:72:
* ipnti,iflpi,iarti,irani,ireci,iredi,nw,nt,icon,is)
1
Error: Type mismatch in argument 'x' at (1); passed REAL(8) to REAL(16)

ModuleVoronoi3D is laden with these issues. More might show elsewhere once these get corrected.

iFort and compilation flags for GFortran might work with this, but the outcome is typically a wildcard and might produce unstable results. This might be the reason GFort compiles but then execution throws segfaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants