forked from BitGo/eth-multisig-v4
-
Notifications
You must be signed in to change notification settings - Fork 0
/
WalletSimple.sol
586 lines (528 loc) · 21 KB
/
WalletSimple.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
// SPDX-License-Identifier: Apache-2.0
pragma solidity 0.8.20;
import './TransferHelper.sol';
import './ERC20Interface.sol';
import './IForwarder.sol';
/** ERC721, ERC1155 imports */
import '@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol';
import '@openzeppelin/contracts/token/ERC1155/utils/ERC1155Holder.sol';
import '@openzeppelin/contracts/utils/Strings.sol';
/**
*
* WalletSimple
* ============
*
* Basic multi-signer wallet designed for use in a co-signing environment where 2 signatures are required to move funds.
* Typically used in a 2-of-3 signing configuration. Uses ecrecover to allow for 2 signatures in a single transaction.
*
* The first signature is created on the operation hash (see Data Formats) and passed to sendMultiSig/sendMultiSigToken
* The signer is determined by verifyMultiSig().
*
* The second signature is created by the submitter of the transaction and determined by msg.signer.
*
* Data Formats
* ============
*
* The signature is created with ethereumjs-util.ecsign(operationHash).
* Like the eth_sign RPC call, it packs the values as a 65-byte array of [r, s, v].
* Unlike eth_sign, the message is not prefixed.
*
* The operationHash the result of keccak256(prefix, toAddress, value, data, expireTime).
* For ether transactions, `prefix` is chain id of the coin i.e. for eth mainnet it is "1".
* For token transaction, `prefix` is chain id + "-ERC20" i.e. for mainnet it is "1-ERC20" and `data` is the tokenContractAddress.
*
*
*/
contract WalletSimple is IERC721Receiver, ERC1155Holder {
// Events
event Deposited(address from, uint256 value, bytes data);
event SafeModeActivated(address msgSender);
event Transacted(
address msgSender, // Address of the sender of the message initiating the transaction
address otherSigner, // Address of the signer (second signature) used to initiate the transaction
bytes32 operation, // Operation hash (see Data Formats)
address toAddress, // The address the transaction was sent to
uint256 value, // Amount of Wei sent to the address
bytes data // Data sent when invoking the transaction
);
event BatchTransfer(address sender, address recipient, uint256 value);
// this event shows the other signer and the operation hash that they signed
// specific batch transfer events are emitted in Batcher
event BatchTransacted(
address msgSender, // Address of the sender of the message initiating the transaction
address otherSigner, // Address of the signer (second signature) used to initiate the transaction
bytes32 operation // Operation hash (see Data Formats)
);
// Public fields
mapping(address => bool) public signers; // The addresses that can co-sign transactions on the wallet
bool public safeMode = false; // When active, wallet may only send to signer addresses
bool public initialized = false; // True if the contract has been initialized
// Internal fields
uint256 private constant MAX_SEQUENCE_ID_INCREASE = 10000;
uint256 constant SEQUENCE_ID_WINDOW_SIZE = 10;
uint256[SEQUENCE_ID_WINDOW_SIZE] recentSequenceIds;
/**
* Set up a simple multi-sig wallet by specifying the signers allowed to be used on this wallet.
* 2 signers will be required to send a transaction from this wallet.
* Note: The sender is NOT automatically added to the list of signers.
* Signers CANNOT be changed once they are set
*
* @param allowedSigners An array of signers on the wallet
*/
function init(address[] calldata allowedSigners) external onlyUninitialized {
require(allowedSigners.length == 3, 'Invalid number of signers');
for (uint8 i = 0; i < allowedSigners.length; i++) {
require(allowedSigners[i] != address(0), 'Invalid signer');
signers[allowedSigners[i]] = true;
}
initialized = true;
}
/**
* Get the network identifier that signers must sign over
* This provides protection signatures being replayed on other chains
* This must be a virtual function because chain-specific contracts will need
* to override with their own network ids. It also can't be a field
* to allow this contract to be used by proxy with delegatecall, which will
* not pick up on state variables
*/
function getNetworkId() internal view virtual returns (string memory) {
return Strings.toString(block.chainid);
}
/**
* Get the network identifier that signers must sign over for token transfers
* This provides protection signatures being replayed on other chains
* This must be a virtual function because chain-specific contracts will need
* to override with their own network ids. It also can't be a field
* to allow this contract to be used by proxy with delegatecall, which will
* not pick up on state variables
*/
function getTokenNetworkId() internal view virtual returns (string memory) {
return string.concat(Strings.toString(block.chainid), '-ERC20');
}
/**
* Get the network identifier that signers must sign over for batch transfers
* This provides protection signatures being replayed on other chains
* This must be a virtual function because chain-specific contracts will need
* to override with their own network ids. It also can't be a field
* to allow this contract to be used by proxy with delegatecall, which will
* not pick up on state variables
*/
function getBatchNetworkId() internal view virtual returns (string memory) {
return string.concat(Strings.toString(block.chainid), '-Batch');
}
/**
* Modifier that will execute internal code block only if the sender is an authorized signer on this wallet
*/
modifier onlySigner() {
require(signers[msg.sender], 'Non-signer in onlySigner method');
_;
}
/**
* Modifier that will execute internal code block only if the contract has not been initialized yet
*/
modifier onlyUninitialized() {
require(!initialized, 'Contract already initialized');
_;
}
/**
* Gets called when a transaction is received with data that does not match any other method
*/
fallback() external payable {
if (msg.value > 0) {
// Fire deposited event if we are receiving funds
emit Deposited(msg.sender, msg.value, msg.data);
}
}
/**
* Gets called when a transaction is received with ether and no data
*/
receive() external payable {
if (msg.value > 0) {
// Fire deposited event if we are receiving funds
// message data is always empty for receive. If there is data it is sent to fallback function.
emit Deposited(msg.sender, msg.value, '');
}
}
/**
* Execute a multi-signature transaction from this wallet using 2 signers: one from msg.sender and the other from ecrecover.
* Sequence IDs are numbers starting from 1. They are used to prevent replay attacks and may not be repeated.
*
* @param toAddress the destination address to send an outgoing transaction
* @param value the amount in Wei to be sent
* @param data the data to send to the toAddress when invoking the transaction
* @param expireTime the number of seconds since 1970 for which this transaction is valid
* @param sequenceId the unique sequence id obtainable from getNextSequenceId
* @param signature see Data Formats
*/
function sendMultiSig(
address toAddress,
uint256 value,
bytes calldata data,
uint256 expireTime,
uint256 sequenceId,
bytes calldata signature
) external onlySigner {
// Verify the other signer
bytes32 operationHash = keccak256(
abi.encode(getNetworkId(), toAddress, value, data, expireTime, sequenceId)
);
address otherSigner = verifyMultiSig(
toAddress,
operationHash,
signature,
expireTime,
sequenceId
);
emit Transacted(
msg.sender,
otherSigner,
operationHash,
toAddress,
value,
data
);
// Success, send the transaction
(bool success, ) = toAddress.call{ value: value }(data);
require(success, 'Call execution failed');
}
/**
* Execute a batched multi-signature transaction from this wallet using 2 signers: one from msg.sender and the other from ecrecover.
* Sequence IDs are numbers starting from 1. They are used to prevent replay attacks and may not be repeated.
* The recipients and values to send are encoded in two arrays, where for index i, recipients[i] will be sent values[i].
*
* @param recipients The list of recipients to send to
* @param values The list of values to send to
* @param expireTime the number of seconds since 1970 for which this transaction is valid
* @param sequenceId the unique sequence id obtainable from getNextSequenceId
* @param signature see Data Formats
*/
function sendMultiSigBatch(
address[] calldata recipients,
uint256[] calldata values,
uint256 expireTime,
uint256 sequenceId,
bytes calldata signature
) external onlySigner {
require(recipients.length != 0, 'Not enough recipients');
require(
recipients.length == values.length,
'Unequal recipients and values'
);
require(recipients.length < 256, 'Too many recipients, max 255');
// Verify the other signer
bytes32 operationHash = keccak256(
abi.encode(
getBatchNetworkId(),
recipients,
values,
expireTime,
sequenceId
)
);
// the first parameter (toAddress) is used to ensure transactions in safe mode only go to a signer
// if in safe mode, we should use normal sendMultiSig to recover, so this check will always fail if in safe mode
require(!safeMode, 'Batch in safe mode');
address otherSigner = verifyMultiSig(
address(0x0),
operationHash,
signature,
expireTime,
sequenceId
);
emit BatchTransacted(msg.sender, otherSigner, operationHash);
batchTransfer(recipients, values);
}
/**
* Transfer funds in a batch to each of recipients
* @param recipients The list of recipients to send to
* @param values The list of values to send to recipients.
* The recipient with index i in recipients array will be sent values[i].
* Thus, recipients and values must be the same length
*/
function batchTransfer(
address[] calldata recipients,
uint256[] calldata values
) private {
for (uint256 i = 0; i < recipients.length; i++) {
require(address(this).balance >= values[i], 'Insufficient funds');
emit BatchTransfer(msg.sender, recipients[i], values[i]);
(bool success, ) = recipients[i].call{ value: values[i] }('');
require(success, 'Call failed');
}
}
/**
* Execute a multi-signature token transfer from this wallet using 2 signers: one from msg.sender and the other from ecrecover.
* Sequence IDs are numbers starting from 1. They are used to prevent replay attacks and may not be repeated.
*
* @param toAddress the destination address to send an outgoing transaction
* @param value the amount in tokens to be sent
* @param tokenContractAddress the address of the erc20 token contract
* @param expireTime the number of seconds since 1970 for which this transaction is valid
* @param sequenceId the unique sequence id obtainable from getNextSequenceId
* @param signature see Data Formats
*/
function sendMultiSigToken(
address toAddress,
uint256 value,
address tokenContractAddress,
uint256 expireTime,
uint256 sequenceId,
bytes calldata signature
) external onlySigner {
// Verify the other signer
bytes32 operationHash = keccak256(
abi.encodePacked(
getTokenNetworkId(),
toAddress,
value,
tokenContractAddress,
expireTime,
sequenceId
)
);
verifyMultiSig(toAddress, operationHash, signature, expireTime, sequenceId);
TransferHelper.safeTransfer(tokenContractAddress, toAddress, value);
}
/**
* Execute a token flush from one of the forwarder addresses. This transfer needs only a single signature and can be done by any signer
*
* @param forwarderAddress the address of the forwarder address to flush the tokens from
* @param tokenContractAddress the address of the erc20 token contract
*/
function flushForwarderTokens(
address payable forwarderAddress,
address tokenContractAddress
) external onlySigner {
IForwarder forwarder = IForwarder(forwarderAddress);
forwarder.flushTokens(tokenContractAddress);
}
/**
* Execute a ERC721 token flush from one of the forwarder addresses. This transfer needs only a single signature and can be done by any signer
*
* @param forwarderAddress the address of the forwarder address to flush the tokens from
* @param tokenContractAddress the address of the erc20 token contract
*/
function flushERC721ForwarderTokens(
address payable forwarderAddress,
address tokenContractAddress,
uint256 tokenId
) external onlySigner {
IForwarder forwarder = IForwarder(forwarderAddress);
forwarder.flushERC721Token(tokenContractAddress, tokenId);
}
/**
* Execute a ERC1155 batch token flush from one of the forwarder addresses.
* This transfer needs only a single signature and can be done by any signer.
*
* @param forwarderAddress the address of the forwarder address to flush the tokens from
* @param tokenContractAddress the address of the erc1155 token contract
*/
function batchFlushERC1155ForwarderTokens(
address payable forwarderAddress,
address tokenContractAddress,
uint256[] calldata tokenIds
) external onlySigner {
IForwarder forwarder = IForwarder(forwarderAddress);
forwarder.batchFlushERC1155Tokens(tokenContractAddress, tokenIds);
}
/**
* Execute a ERC1155 token flush from one of the forwarder addresses.
* This transfer needs only a single signature and can be done by any signer.
*
* @param forwarderAddress the address of the forwarder address to flush the tokens from
* @param tokenContractAddress the address of the erc1155 token contract
* @param tokenId the token id associated with the ERC1155
*/
function flushERC1155ForwarderTokens(
address payable forwarderAddress,
address tokenContractAddress,
uint256 tokenId
) external onlySigner {
IForwarder forwarder = IForwarder(forwarderAddress);
forwarder.flushERC1155Tokens(tokenContractAddress, tokenId);
}
/**
* Sets the autoflush 721 parameter on the forwarder.
*
* @param forwarderAddress the address of the forwarder to toggle.
* @param autoFlush whether to autoflush erc721 tokens
*/
function setAutoFlush721(address forwarderAddress, bool autoFlush)
external
onlySigner
{
IForwarder forwarder = IForwarder(forwarderAddress);
forwarder.setAutoFlush721(autoFlush);
}
/**
* Sets the autoflush 721 parameter on the forwarder.
*
* @param forwarderAddress the address of the forwarder to toggle.
* @param autoFlush whether to autoflush erc1155 tokens
*/
function setAutoFlush1155(address forwarderAddress, bool autoFlush)
external
onlySigner
{
IForwarder forwarder = IForwarder(forwarderAddress);
forwarder.setAutoFlush1155(autoFlush);
}
/**
* Do common multisig verification for both eth sends and erc20token transfers
*
* @param toAddress the destination address to send an outgoing transaction
* @param operationHash see Data Formats
* @param signature see Data Formats
* @param expireTime the number of seconds since 1970 for which this transaction is valid
* @param sequenceId the unique sequence id obtainable from getNextSequenceId
* returns address that has created the signature
*/
function verifyMultiSig(
address toAddress,
bytes32 operationHash,
bytes calldata signature,
uint256 expireTime,
uint256 sequenceId
) private returns (address) {
address otherSigner = recoverAddressFromSignature(operationHash, signature);
// Verify if we are in safe mode. In safe mode, the wallet can only send to signers
require(!safeMode || signers[toAddress], 'External transfer in safe mode');
// Verify that the transaction has not expired
require(expireTime >= block.timestamp, 'Transaction expired');
// Try to insert the sequence ID. Will revert if the sequence id was invalid
tryInsertSequenceId(sequenceId);
require(signers[otherSigner], 'Invalid signer');
require(otherSigner != msg.sender, 'Signers cannot be equal');
return otherSigner;
}
/**
* ERC721 standard callback function for when a ERC721 is transfered.
*
* @param _operator The address of the nft contract
* @param _from The address of the sender
* @param _tokenId The token id of the nft
* @param _data Additional data with no specified format, sent in call to `_to`
*/
function onERC721Received(
address _operator,
address _from,
uint256 _tokenId,
bytes memory _data
) external virtual override returns (bytes4) {
return this.onERC721Received.selector;
}
/**
* @inheritdoc ERC1155Holder
*/
function onERC1155Received(
address _operator,
address _from,
uint256 id,
uint256 value,
bytes memory data
) public virtual override returns (bytes4) {
return this.onERC1155Received.selector;
}
/**
* @inheritdoc ERC1155Holder
*/
function onERC1155BatchReceived(
address _operator,
address _from,
uint256[] memory ids,
uint256[] memory values,
bytes memory data
) public virtual override returns (bytes4) {
return this.onERC1155BatchReceived.selector;
}
/**
* Irrevocably puts contract into safe mode. When in this mode, transactions may only be sent to signing addresses.
*/
function activateSafeMode() external onlySigner {
safeMode = true;
emit SafeModeActivated(msg.sender);
}
/**
* Gets signer's address using ecrecover
* @param operationHash see Data Formats
* @param signature see Data Formats
* returns address recovered from the signature
*/
function recoverAddressFromSignature(
bytes32 operationHash,
bytes memory signature
) private pure returns (address) {
require(signature.length == 65, 'Invalid signature - wrong length');
// We need to unpack the signature, which is given as an array of 65 bytes (like eth.sign)
bytes32 r;
bytes32 s;
uint8 v;
// solhint-disable-next-line
assembly {
r := mload(add(signature, 32))
s := mload(add(signature, 64))
v := and(mload(add(signature, 65)), 255)
}
if (v < 27) {
v += 27; // Ethereum versions are 27 or 28 as opposed to 0 or 1 which is submitted by some signing libs
}
// protect against signature malleability
// S value must be in the lower half orader
// reference: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/051d340171a93a3d401aaaea46b4b62fa81e5d7c/contracts/cryptography/ECDSA.sol#L53
require(
uint256(s) <=
0x7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF5D576E7357A4501DDFE92F46681B20A0,
"ECDSA: invalid signature 's' value"
);
// note that this returns 0 if the signature is invalid
// Since 0x0 can never be a signer, when the recovered signer address
// is checked against our signer list, that 0x0 will cause an invalid signer failure
return ecrecover(operationHash, v, r, s);
}
/**
* Verify that the sequence id has not been used before and inserts it. Throws if the sequence ID was not accepted.
* We collect a window of up to 10 recent sequence ids, and allow any sequence id that is not in the window and
* greater than the minimum element in the window.
* @param sequenceId to insert into array of stored ids
*/
function tryInsertSequenceId(uint256 sequenceId) private {
// Keep a pointer to the lowest value element in the window
uint256 lowestValueIndex = 0;
// fetch recentSequenceIds into memory for function context to avoid unnecessary sloads
uint256[SEQUENCE_ID_WINDOW_SIZE]
memory _recentSequenceIds = recentSequenceIds;
for (uint256 i = 0; i < SEQUENCE_ID_WINDOW_SIZE; i++) {
require(_recentSequenceIds[i] != sequenceId, 'Sequence ID already used');
if (_recentSequenceIds[i] < _recentSequenceIds[lowestValueIndex]) {
lowestValueIndex = i;
}
}
// The sequence ID being used is lower than the lowest value in the window
// so we cannot accept it as it may have been used before
require(
sequenceId > _recentSequenceIds[lowestValueIndex],
'Sequence ID below window'
);
// Block sequence IDs which are much higher than the lowest value
// This prevents people blocking the contract by using very large sequence IDs quickly
require(
sequenceId <=
(_recentSequenceIds[lowestValueIndex] + MAX_SEQUENCE_ID_INCREASE),
'Sequence ID above maximum'
);
recentSequenceIds[lowestValueIndex] = sequenceId;
}
/**
* Gets the next available sequence ID for signing when using executeAndConfirm
* returns the sequenceId one higher than the highest currently stored
*/
function getNextSequenceId() external view returns (uint256) {
uint256 highestSequenceId = 0;
for (uint256 i = 0; i < SEQUENCE_ID_WINDOW_SIZE; i++) {
if (recentSequenceIds[i] > highestSequenceId) {
highestSequenceId = recentSequenceIds[i];
}
}
return highestSequenceId + 1;
}
}