Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set preventBodyShift to true in the examples #228

Open
papb opened this issue Dec 11, 2019 · 3 comments
Open

Set preventBodyShift to true in the examples #228

papb opened this issue Dec 11, 2019 · 3 comments

Comments

@papb
Copy link

papb commented Dec 11, 2019

Running the examples in https://alertifyjs.com/ cause the body to shift because the vertical scrollbar disappears. I was about to open an issue about this but I saw #167. So there is already a way to do it, which seems to be the preventBodyShift option.

This issue is to suggest that preventBodyShift is set on the examples in https://alertifyjs.com/ because it is a bit discouraging to see a body shift like this in the first example.

@MohammadYounes
Copy link
Owner

The docs uses the defaults, I think it will be okay to set preventBodyShift in home page.

@papb
Copy link
Author

papb commented Dec 14, 2019

@MohammadYounes thanks! By the way can you give an example of situation in which the preventBodyShift option would be undesirable?

@MohammadYounes
Copy link
Owner

@papb It's a developer preference. Some may go for padding the body to accommodate the missing scrollbar instead of having a disabled one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants