Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating window in lsp_signature.nvim looks wrong #45

Open
graves501 opened this issue Sep 14, 2022 · 4 comments
Open

Floating window in lsp_signature.nvim looks wrong #45

graves501 opened this issue Sep 14, 2022 · 4 comments

Comments

@graves501
Copy link

When using the dracula theme with lsp_signature.nvim the floating window looks very bad. Since the looks are colorscheme related according to the lsp_signature.nvim FAQ, someone might want look into fixing it for everyone:

Q:I do not like the pop window background highlight, how to change it?

A: Redefine your NormalFloat and FloatBorder, esp if your colorscheme dose not define it.

image

This is how the floating window looks with the colorscheme nord:

image

@Mofiqul
Copy link
Owner

Mofiqul commented Sep 15, 2022

I will look into it. FYI: you can override it with setup function.

@graves501
Copy link
Author

Thanks for your time!

In the meantime I tried (re)setting NormalFloat and FloatBorder manually and it seemed like it helped:

vim.api.nvim_set_hl(0, "NormalFloat", {})
vim.api.nvim_set_hl(0, "FloatBorder", {})

image

@banjo
Copy link

banjo commented Jun 18, 2024

Any news on this? The provided code does not seem to work for me.

@banjo
Copy link

banjo commented Jun 18, 2024

Did not manage to get any borders, but this config at least makes it a big darker so it's easier to differentiate:

  {
    "Mofiqul/dracula.nvim",
    config = function()
      require("dracula").setup({
        overrides = function(colors)
          return {
            NormalFloat = { fg = colors.fg, bg = colors.menu },
          }
        end,
      })
    end,
  },

EDIT:

Another solution to add borders if you are using LazyVim or more specifically noice:

return {
  "folke/noice.nvim",
  enabled = true,
  opts = {
    presets = {
      lsp_doc_border = true,
    },
  },
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants