Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Original SHAP Visualizations #21

Open
jlevy44 opened this issue Sep 9, 2019 · 8 comments
Open

Support for Original SHAP Visualizations #21

jlevy44 opened this issue Sep 9, 2019 · 8 comments

Comments

@jlevy44
Copy link

jlevy44 commented Sep 9, 2019

Hey there!

Nice package! I'm primarily a python user, but many of my colleagues would find this useful. Will there be support for the visualization modules introduced in the original SHAP repo? Namely their summary and force plots? Happy to PR.

Thanks!

@agosiewska
Copy link
Member

Yeah, sure! All PRs are welcome :)
I was trying to add support for visualizations from the original shap, but I couldn't integrate their javascripts with RStudio viewer.

@jlevy44
Copy link
Author

jlevy44 commented Sep 16, 2019

Ah I see. You could try setting "matplotlib=True" for summary and force plots, if that helps at all. I can also PR it. But it should disable the javascript during plotting.

@maksymiuks
Copy link
Member

First of all, thank You so much! :)

Indeed, that could work. Feel free to PR if You have sth ready to go. Unfortunately I'm quite short on time these days and can do it on my own not before October.

@jlevy44
Copy link
Author

jlevy44 commented Sep 25, 2019

I'll see what I can do. Also short on time as well.

@jznv
Copy link

jznv commented Aug 7, 2020

I could use the original visualizations! If I do a PR, would anyone be around to pull it?

@agosiewska
Copy link
Member

Sure :)

@bgreenwell
Copy link

bgreenwell commented Mar 4, 2021

Cool package. If you guys are still working to integrate the original shap visualizations, I have an example in {fastshap} using forceplot(). Works fine in and out of RStudio and in Rmarkdown, as far as I can tell: https://github.com/bgreenwell/fastshap/blob/master/R/force_plot.R

You’d need to make a few slight changes to adapt to your output. Same idea should work for the other visualizations as well.

@agosiewska
Copy link
Member

Hey! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants